Attention is currently required from: Nico Huber, Michał Żygowski.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61682 )
Change subject: nb/amd/common: Move RAM calcualtion to common code
......................................................................
Patch Set 3:
(1 comment)
File src/northbridge/amd/common/ram_calc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-140305):
https://review.coreboot.org/c/coreboot/+/61682/comment/56ab4439_0d6c529b
PS3, Line 45: /* [N-1:40] at [N-1-40:0] addres_smask will clear unused high bits */
'addres' may be misspelled - perhaps 'address'?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61682
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3d222f6cbd26fe78d968d2883984f25e8b62ab5c
Gerrit-Change-Number: 61682
Gerrit-PatchSet: 3
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 13:34:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment