Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80735?usp=email )
Change subject: lib: Explicitly declare heap as NOLOAD
......................................................................
Patch Set 5:
(1 comment)
File src/lib/program.ld:
https://review.coreboot.org/c/coreboot/+/80735/comment/ab45cdf7_2bbbe4b9 :
PS4, Line 120: .bss . : {
I mean, Max is right: the BSS should also have the NOLOAD flag. […]
Yes. LOAD means that bytes are loaded from the file into memory for this section. ALLOC means that this section has an area of memory allocated for it. For sections that are ALLOC but not LOAD, their memory area is implicitly zeroed (I don't think you can turn the zeroing part off, because ELF was designed for userspace programs and in that context the kernel cannot give you "uninitialized" memory anyway because it's not allowed to risk leaking data from other programs).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/80735?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I3ca7221d10f144f608823e0b9624533780fbf335
Gerrit-Change-Number: 80735
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-Comment-Date: Tue, 27 Feb 2024 19:24:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Maximilian Brune
maximilian.brune@9elements.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment