Subrata Banik has posted comments on this change. ( https://review.coreboot.org/19428 )
Change subject: soc/intel/common/block: Add Intel XDCI code support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/include/i... File src/soc/intel/common/block/include/intelblocks/xdci.h:
Line 22:
one too many new lines?
Done
https://review.coreboot.org/#/c/19428/1/src/soc/intel/common/block/xdci/xdci... File src/soc/intel/common/block/xdci/xdci.c:
PS1, Line 33: 0x5aaa, /* ApolloLake */ : 0x31aa, /* GLK */ : 0x9d30, /* SunRisePoint LP */
I've mentioned this in other CLs. I think it'd be good to move all of these
Done
Line 42: .devices = pci_device_ids,
It's interesting we're repeating the boiler plate and then only providing a
make sense, but only concern is that init/some APIs which may need to implement inside SOC as an overridden mechanism. Implementing those might be little tricky because of some many like this
static struct device_operations usb_xdci_ops = { .read_resources = &pci_dev_read_resources, .set_resources = &pci_dev_set_resources, .enable_resources = &pci_dev_enable_resources, #if (pci_device_ids == XDCI) .init = soc_xdci_init, #if (pci_device_ids == XHCI) .init = soc_xhci_init, #if (pci_device_ids == XYZZ) .init = soc_xyzz_init, };
-
Subrata Banik (Code Review)