Change in coreboot[master]: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 k...
Johnny Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43055 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 394kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8555f6979221c92c87abe1ea75d72b91c1bdec70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43055/1
diff --git a/src/mainboard/google/volteer/variants/volteer/overridetree.cb b/src/mainboard/google/volteer/variants/volteer/overridetree.cb index 24b869c..6549932 100644 --- a/src/mainboard/google/volteer/variants/volteer/overridetree.cb +++ b/src/mainboard/google/volteer/variants/volteer/overridetree.cb @@ -161,5 +161,49 @@ end end end # PMC + # Intel Common SoC Config + #+-------------------+---------------------------+ + #| Field | Value | + #+-------------------+---------------------------+ + #| chipset_lockdown | CHIPSET_LOCKDOWN_COREBOOT | + #| GSPI0 | cr50 TPM. Early init is | + #| | required to set up a BAR | + #| | for TPM communication | + #| | before memory is up | + #| GSPI1 | Fingerprint MCU | + #| I2C0 | Audio | + #| I2C1 | Touchscreen | + #| I2C2 | WLAN, SAR0 | + #| I2C3 | Camera, SAR1 | + #| I2C5 | Trackpad | + #+-------------------+---------------------------+ + register "common_soc_config" = "{ + .chipset_lockdown = CHIPSET_LOCKDOWN_COREBOOT, + .gspi[0] = { + .speed_mhz = 1, + .early_init = 1, + }, + .i2c[0] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[1] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[2] = { + .speed = I2C_SPEED_FAST, + .speed_config[0] = { + .speed = I2C_SPEED_FAST, + .scl_lcnt = 163, + .scl_hcnt = 75, + .sda_hold = 36, + }, + }, + .i2c[3] = { + .speed = I2C_SPEED_FAST, + }, + .i2c[5] = { + .speed = I2C_SPEED_FAST, + }, + }" end end
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43055
to look at the new patch set (#2).
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8555f6979221c92c87abe1ea75d72b91c1bdec70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 44 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43055/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43055 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
Patch Set 2: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/43055/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43055/2//COMMIT_MSG@7 PS2, Line 7: Turn Do you mean *Tune* instead of *Turn*?
https://review.coreboot.org/c/coreboot/+/43055/2//COMMIT_MSG@12 PS2, Line 12: 400kHz *400 kHz* with space for consistency?
https://review.coreboot.org/c/coreboot/+/43055/2//COMMIT_MSG@15 PS2, Line 15: 380kHz Ditto.
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43055
to look at the new patch set (#3).
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8555f6979221c92c87abe1ea75d72b91c1bdec70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43055/3
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43055
to look at the new patch set (#4).
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8555f6979221c92c87abe1ea75d72b91c1bdec70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43055/4
Hello build bot (Jenkins), Paul Menzel,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/43055
to look at the new patch set (#5).
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN
The current I2C2 bus frequency is 344 kHZ, which does not meet the spec. This change updates scl_lcnt, scl_hcnt, sda_hold value for I2C2 to bring the bus frequency closer to 400 kHz.
BUG=b:153588771 TEST=Verified that I2C2 frequency is 380 kHz.
Signed-off-by: Johnny Li johnny_li@wistron.corp-partner.google.com Change-Id: I8555f6979221c92c87abe1ea75d72b91c1bdec70 --- M src/mainboard/google/volteer/variants/volteer/overridetree.cb 1 file changed, 32 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/43055/5
Johnny Li has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/43055 )
Change subject: mb/google/volteer/variant/volteer: Turn I2C2 bus freq closer to 400 kHz for WLAN ......................................................................
Abandoned
-
Johnny Li (Code Review) -
Paul Menzel (Code Review)