Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37762 )
Change subject: Documentation/Intel: s5 charging applet design document
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_...
File Documentation/soc/intel/s5_charging_applet/s5_charging_applet.md:
https://review.coreboot.org/c/coreboot/+/37762/4/Documentation/soc/intel/s5_...
PS4, Line 86: charging applet onto screen.
@Paul, can you please help to understand why its against coreboot principal ?
coreboot is about only initializing the necessary hardware, so payloads can start. Displaying something on the screen is not part of that. So, displaying something on the screen cannot be part of coreboot, and the spec needs to address some payload.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibb0d70d81890a60212c914b6bc2bfc7e35479ba9
Gerrit-Change-Number: 37762
Gerrit-PatchSet: 4
Gerrit-Owner: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Comment-Date: Wed, 18 Mar 2020 20:46:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment