Attention is currently required from: Evan Green, Tim Wawrzynczak, Sridhar Siricilla.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63932 )
Change subject: soc/intel/common: Skip sending DISCONNECT IPC command
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/common/block/tcss/tcss.c:
https://review.coreboot.org/c/coreboot/+/63932/comment/48faff51_263a4410
PS2, Line 433: if (ps->prev_sleep_state != ACPI_S3 && ps->prev_sleep_state != ACPI_S4) {
Yes, S4 and S5 are same. coreboot must send the command in the S4 scenario. Looks like I missed to update the CL.
so, we are relying on XHCI driver fix for S4 as well.
@Evan, JFYI
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63932
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ad006ae8677919c7dfeca8eec0af11454a2e89d
Gerrit-Change-Number: 63932
Gerrit-PatchSet: 3
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Evan Green
evgreen@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Evan Green
evgreen@chromium.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 11 May 2022 03:42:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Evan Green
evgreen@chromium.org
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment