Attention is currently required from: Angel Pons, Maximilian Brune.
Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74121 )
Change subject: [RFC] drivers/option: Add option list in cbtable ......................................................................
Patch Set 1:
(1 comment)
File src/drivers/option/cfr.c:
https://review.coreboot.org/c/coreboot/+/74121/comment/83dc5688_e73e6c5a PS1, Line 127: write_body(header); : : menu->size = sm_compute_record_size((char *)menu, header);
A thought: if we let the boot-state machine do this, then silicon, platform drivers, board code, etc […]
I should be sleeping at 2am instead - this would fragment the CFR into 'actual' tags rather than one effective structure. I still like the theory of it, but implementing it with CBTABLE rules would mean gathering up forms. Besides, we currently offload the option table responsibility to the board.
Is it worth dedicated `CB_TAG_CFR_{SILICON,BOARD}_FORM` tags? We have to exclude drivers.