Change in coreboot[master]: [WIP] soc/amd/picasso: add FSP binary location

[Felix Held (Code Review)]

Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42472 )

Change subject: [WIP] soc/amd/picasso: add FSP binary location
......................................................................

[WIP] soc/amd/picasso: add FSP binary location

Since the blobs haven't landed yet, it is expected that this breaks the
Jenkins build.

Change-Id: Ib2241cc90c7113e0c3de4409e08b9ae1f4c2f51e
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42472/1

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index dd5731d..bf809f8 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -60,6 +60,20 @@
    string
    default "src/soc/amd/picasso/memlayout.ld"

+config FSP_M_FILE
+	string "FSP-M (memory init) binary path and filename"
+	depends on ADD_FSP_BINARIES
+	default "3rdparty/amd_blobs/picasso/PICASSO_M.fd"
+	help
+	  The path and filename of the FSP-M binary for this platform.
+
+config FSP_S_FILE
+	string "FSP-S (silicon init) binary path and filename"
+	depends on ADD_FSP_BINARIES
+	default "3rdparty/amd_blobs/picasso/PICASSO_S.fd"
+	help
+	  The path and filename of the FSP-S binary for this platform.
+
 config EARLY_RESERVED_DRAM_BASE
    hex
    default 0x2000000

Change in coreboot[master]: soc/amd/picasso: add FSP binary location

[Felix Held (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42472

to look at the new patch set (#2).

Change subject: soc/amd/picasso: add FSP binary location
......................................................................

soc/amd/picasso: add FSP binary location

Since the blobs haven't landed yet, it is expected that this breaks the
Jenkins build.

Change-Id: Ib2241cc90c7113e0c3de4409e08b9ae1f4c2f51e
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42472/2

Change in coreboot[master]: soc/amd/picasso: add FSP binary location

[Raul Rangel (Code Review)]

Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42472 )

Change subject: soc/amd/picasso: add FSP binary location
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: soc/amd/picasso: add FSP binary location

[Felix Held (Code Review)]

Hello build bot (Jenkins), Raul Rangel,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/42472

to look at the new patch set (#6).

Change subject: soc/amd/picasso: add FSP binary location
......................................................................

soc/amd/picasso: add FSP binary location

Now that the initial version of the Picasso FSP binaries have finally
landed, we can set the default paths to point to them now.

Change-Id: Ib2241cc90c7113e0c3de4409e08b9ae1f4c2f51e
Signed-off-by: Felix Held 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 14 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/72/42472/6

Change in coreboot[master]: soc/amd/picasso: add FSP binary location

[Marshall Dawson (Code Review)]

Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42472 )

Change subject: soc/amd/picasso: add FSP binary location
......................................................................

Patch Set 6: Code-Review+2

Change in coreboot[master]: soc/amd/picasso: add FSP binary location

[Jason Glenesk (Code Review)]

Jason Glenesk has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42472 )

Change subject: soc/amd/picasso: add FSP binary location
......................................................................

Patch Set 6: Code-Review+1

Change in coreboot[master]: soc/amd/picasso: add FSP binary location

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42472 )

Change subject: soc/amd/picasso: add FSP binary location
......................................................................

soc/amd/picasso: add FSP binary location

Now that the initial version of the Picasso FSP binaries have finally
landed, we can set the default paths to point to them now.

Change-Id: Ib2241cc90c7113e0c3de4409e08b9ae1f4c2f51e
Signed-off-by: Felix Held 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/42472
Reviewed-by: Marshall Dawson 
Reviewed-by: Jason Glenesk 
Tested-by: build bot (Jenkins) 
---
M src/soc/amd/picasso/Kconfig
1 file changed, 14 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Marshall Dawson: Looks good to me, approved
  Jason Glenesk: Looks good to me, but someone else must approve

diff --git a/src/soc/amd/picasso/Kconfig b/src/soc/amd/picasso/Kconfig
index 7bcc316..7f32c3c 100644
--- a/src/soc/amd/picasso/Kconfig
+++ b/src/soc/amd/picasso/Kconfig
@@ -58,6 +58,20 @@
    select SUPPORT_CPU_UCODE_IN_CBFS
    select ACPI_NO_SMI_GNVS

+config FSP_M_FILE
+	string "FSP-M (memory init) binary path and filename"
+	depends on ADD_FSP_BINARIES
+	default "3rdparty/amd_blobs/picasso/PICASSO_M.fd"
+	help
+	  The path and filename of the FSP-M binary for this platform.
+
+config FSP_S_FILE
+	string "FSP-S (silicon init) binary path and filename"
+	depends on ADD_FSP_BINARIES
+	default "3rdparty/amd_blobs/picasso/PICASSO_S.fd"
+	help
+	  The path and filename of the FSP-S binary for this platform.
+
 config EARLY_RESERVED_DRAM_BASE
    hex
    default 0x2000000