Attention is currently required from: Andrey Petrov, Patrick Rudolph. Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/60638 )
Change subject: drivers/intel/fsp2_0/notify.c: Clean up some cosmetics ......................................................................
drivers/intel/fsp2_0/notify.c: Clean up some cosmetics
Sort includes alphabetically, drop spaces after type casts and unbreak some long lines that are less than 96 characters long.
Tested with BUILD_TIMELESS=1, Prodrive Hermes remains identical.
Change-Id: I2dafd677abbdd892745fea1bf4414f6e0d5549bb Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/intel/fsp2_0/notify.c 1 file changed, 8 insertions(+), 12 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/38/60638/1
diff --git a/src/drivers/intel/fsp2_0/notify.c b/src/drivers/intel/fsp2_0/notify.c index 9a0f23a..b3563c0 100644 --- a/src/drivers/intel/fsp2_0/notify.c +++ b/src/drivers/intel/fsp2_0/notify.c @@ -4,19 +4,19 @@ #include <console/console.h> #include <cpu/x86/mtrr.h> #include <fsp/util.h> -#include <timestamp.h> #include <mode_switch.h> +#include <timestamp.h>
static void fsp_notify(enum fsp_notify_phase phase) { - uint32_t ret; - fsp_notify_fn fspnotify; struct fsp_notify_params notify_params = { .phase = phase }; + fsp_notify_fn fspnotify; + uint32_t ret;
if (!fsps_hdr.notify_phase_entry_offset) die("Notify_phase_entry_offset is zero!\n");
- fspnotify = (void *) (uintptr_t)(fsps_hdr.image_base + + fspnotify = (void *)(uintptr_t)(fsps_hdr.image_base + fsps_hdr.notify_phase_entry_offset); fsp_before_debug_notify(fspnotify, ¬ify_params);
@@ -68,14 +68,10 @@ fsp_notify(END_OF_FIRMWARE); }
-BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fsp_notify_dummy, - (void *) AFTER_PCI_ENUM); -BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_EXIT, fsp_notify_dummy, - (void *) READY_TO_BOOT); -BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, fsp_notify_dummy, - (void *) READY_TO_BOOT); +BOOT_STATE_INIT_ENTRY(BS_DEV_ENABLE, BS_ON_ENTRY, fsp_notify_dummy, (void *)AFTER_PCI_ENUM); +BOOT_STATE_INIT_ENTRY(BS_PAYLOAD_LOAD, BS_ON_EXIT, fsp_notify_dummy, (void *)READY_TO_BOOT); +BOOT_STATE_INIT_ENTRY(BS_OS_RESUME, BS_ON_ENTRY, fsp_notify_dummy, (void *)READY_TO_BOOT);
-__weak void platform_fsp_notify_status( - enum fsp_notify_phase phase) +__weak void platform_fsp_notify_status(enum fsp_notify_phase phase) { }