Philipp Deppenwiese has submitted this change and it was merged. ( https://review.coreboot.org/29601 )
Change subject: util/scripts/maintainers.go: Stub support for website tag ......................................................................
util/scripts/maintainers.go: Stub support for website tag
ME Cleaner's component has an entry specifying its website, which this parser didn't know how to handle. Avoid the resulting warning.
While at it, de-C the switch statement and make it work go-style. This also fixes "R" statements being ignored.
Change-Id: Ifc23e28daba9d85bf690557a80134accea8bed21 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/29601 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com --- M util/scripts/maintainers.go 1 file changed, 7 insertions(+), 32 deletions(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved Philipp Deppenwiese: Looks good to me, approved
diff --git a/util/scripts/maintainers.go b/util/scripts/maintainers.go index 03c7709..a457581 100644 --- a/util/scripts/maintainers.go +++ b/util/scripts/maintainers.go @@ -95,40 +95,15 @@ current.name = line } else { switch line[0] { - case 'R': - case 'M': - { - /* Add subsystem maintainer */ - current.maintainer = - append(current.maintainer, - line[3:len(line)]) - break - } - case 'S': - { - break - } - case 'L': - { - break - } - case 'T': - { - break - } + case 'R', 'M': + /* Add subsystem maintainer */ + current.maintainer = append(current.maintainer, line[3:len(line)]) case 'F': - { - // add files - current.file = - append(current.file, - line[3:len(line)]) - break - } + // add files + current.file = append(current.file, line[3:len(line)]) + case 'L', 'S', 'T', 'W': // ignore default: - { - fmt.Println("No such specifier: ", line) - break - } + fmt.Println("No such specifier: ", line) } } }