Change in coreboot[master]: commonlib: Add CBFS_TYPE_BOOTBLOCK

[Wim Vervoorn (Code Review)]

Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41824 )

Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................

commonlib: Add CBFS_TYPE_BOOTBLOCK

Add CBFS_TYPE_BOOTBLOCK to allow accessing the bootblock as a CBFS file.

BUG=N/A
TEST=build

Change-Id: Ibb03ac3a6cd8711e0402e47335bb8e110c6ef61a
Signed-off-by: Wim Vervoorn 
---
M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
1 file changed, 1 insertion(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/24/41824/1

diff --git a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
index d2fc626..af4baf5 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
@@ -21,6 +21,7 @@

#define CBFS_TYPE_DELETED    0x00000000
 #define CBFS_TYPE_DELETED2   0xffffffff
+#define CBFS_TYPE_BOOTBLOCK  0x01
 #define CBFS_TYPE_STAGE      0x10
 #define CBFS_TYPE_SELF       0x20
 #define CBFS_TYPE_FIT        0x21

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41824 )

Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................

Patch Set 4: Code-Review+2

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41824 )

Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/41824/4//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/41824/4//COMMIT_MSG@9 
PS4, Line 9: Add CBFS_TYPE_BOOTBLOCK to allow accessing the bootblock as a CBFS file.
Note that you don't *need* to specify the type to access a file, you can always just pass NULL for the type to cbfs_boot_locate() (in fact I think most of the code that does an explicit type lookup probably doesn't need to and shouldn't).

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41824 )

Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................

Patch Set 5: Code-Review+1

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41824 )

Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................

commonlib: Add CBFS_TYPE_BOOTBLOCK

Add CBFS_TYPE_BOOTBLOCK to allow accessing the bootblock as a CBFS file.

BUG=N/A
TEST=build

Change-Id: Ibb03ac3a6cd8711e0402e47335bb8e110c6ef61a
Signed-off-by: Wim Vervoorn 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41824
Reviewed-by: Kyösti Mälkki 
Reviewed-by: Frans Hendriks 
Tested-by: build bot (Jenkins) 
---
M src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Kyösti Mälkki: Looks good to me, but someone else must approve
  Frans Hendriks: Looks good to me, approved

diff --git a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
index d2fc626..af4baf5 100644
--- a/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
+++ b/src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h
@@ -21,6 +21,7 @@

#define CBFS_TYPE_DELETED    0x00000000
 #define CBFS_TYPE_DELETED2   0xffffffff
+#define CBFS_TYPE_BOOTBLOCK  0x01
 #define CBFS_TYPE_STAGE      0x10
 #define CBFS_TYPE_SELF       0x20
 #define CBFS_TYPE_FIT        0x21

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41824 )

Change subject: commonlib: Add CBFS_TYPE_BOOTBLOCK
......................................................................

Patch Set 6:

Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4
Emulation targets:
"QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4536
"QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4535
"QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4534
"QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4533

Please note: This test is under development and might not be accurate at all!