Attention is currently required from: Michał Żygowski, Paul Menzel, Arthur Heymans.
Michał Kopeć has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59807 )
Change subject: nb/amd/agesa/family14: Enable PARALLEL_MP
......................................................................
Patch Set 19:
(1 comment)
File src/northbridge/amd/agesa/family14/northbridge.c:
https://review.coreboot.org/c/coreboot/+/59807/comment/04105100_23dc34bb
PS16, Line 321: uint8_t siblings = cpuid_ecx(0x80000008) & 0xff;
:
: return siblings + 1;
Should this change? It looks like most other AMD code does read this from the PCI config space.
Looks like only stoneyridge reads this from PCI config space, soc/amd/common/block also reads the cpu count from CPUID.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59807
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39a0779bdf115eebe31290591152b920acde773e
Gerrit-Change-Number: 59807
Gerrit-PatchSet: 19
Gerrit-Owner: Michał Kopeć
michal.kopec@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Tue, 12 Apr 2022 13:50:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment