Change in ...coreboot[master]: google/krane: Add Panel auo kd101n80-45na support.

[jitao shi (Code Review)]

jitao shi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33413

Change subject: google/krane: Add Panel auo kd101n80-45na support.
......................................................................

google/krane: Add Panel auo kd101n80-45na support.

Add panel kd101n80-45na driver for Krane.

BUG=b:129299873
BRANCH=none

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/display.h
M src/mainboard/google/kukui/panel_krane.c
2 files changed, 36 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/1

diff --git a/src/mainboard/google/kukui/display.h b/src/mainboard/google/kukui/display.h
index d7b8bd9..87a381c 100644
--- a/src/mainboard/google/kukui/display.h
+++ b/src/mainboard/google/kukui/display.h
@@ -32,6 +32,7 @@

enum krane_panel_id {
    PANEL_KRANE_FIRST = 0,
+	PANEL_KRANE_AUO_KD101N80_45NA = 0,
    PANEL_KRANE_BOE_TV101WUM_NL6,
    PANEL_KRANE_UNKNOWN,
    PANEL_KRANE_COUNT,
diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c
index 1011bfd..7a803aa 100644
--- a/src/mainboard/google/kukui/panel_krane.c
+++ b/src/mainboard/google/kukui/panel_krane.c
@@ -27,6 +27,8 @@
 #include "display.h"
 #include "gpio.h"

+#define KRANE_PANEL_ID_BIT_POSITION 4
+
 static struct edid krane_boe_tv101wum_nl6_edid = {
    .panel_bits_per_color = 8,
    .panel_bits_per_pixel = 24,
@@ -42,6 +44,21 @@
    	 },
 };

+static struct edid krane_auo_kd101n80_45na_edid = {
+	.panel_bits_per_color = 8,
+	.panel_bits_per_pixel = 24,
+	.mode = {
+		 .name = "1200x1920@60Hz",
+		 .pixel_clock = 157000,
+		 .lvds_dual_channel = 0,
+		 .refresh = 60,
+		 .ha = 1200, .hbl = 140, .hso = 80, .hspw = 24, .hborder = 0,
+		 .va = 1920, .vbl = 36, .vso = 16, .vspw = 4, .vborder = 0,
+		 .phsync = '-', .pvsync = '-',
+		 .x_mm = 135, .y_mm = 216,
+		 },
+};
+
 struct lcm_init_table boe_tv101wum_nl6_init_cmd[] = {
    {DELAY_CMD, 24, {} },
    {INIT_DCS_CMD, 2, { 0xB0, 0x05 } },
@@ -337,7 +354,23 @@
    {DELAY_CMD, 150, {} },
 };

+struct lcm_init_table auo_kd101n80_45na_init_cmd[] = {
+	{DELAY_CMD, 24, {} },
+	{INIT_DCS_CMD, 2, { 0xB0, 0x05 } },
+	{INIT_DCS_CMD, 2, { 0xB1, 0xE5 } },
+	{INIT_DCS_CMD, 2, { 0xB3, 0x52 } },
+	{INIT_DCS_CMD, 2, { 0xB0, 0x00 } },
+	{INIT_DCS_CMD, 2, { 0xB3, 0x08 } },
+	{INIT_DCS_CMD, 2, { 0xB0, 0x04 } },
+	{INIT_DCS_CMD, 2, { 0xB8, 0x68 } },
+	{DELAY_CMD, 150, {} },
+};
+
 struct panel_info krane_panel_info[] = {
+	PANEL(PANEL_KRANE_AUO_KD101N80_45NA,
+	      74000,
+	      krane_auo_kd101n80_45na_edid,
+	      auo_kd101n80_45na_init_cmd),
    PANEL(PANEL_KRANE_BOE_TV101WUM_NL6,
          74000,
          krane_boe_tv101wum_nl6_edid,
@@ -348,7 +381,8 @@

static union panel_id krane_get_panel_id(struct board_display_intf *intf)
 {
-	return (union panel_id)PANEL_KRANE_BOE_TV101WUM_NL6;
+	return (union panel_id)
+			((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf);
 };

static bool krane_is_panel_id_valid(union panel_id id)

[jitao shi (Code Review)]

jitao shi has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: google/krane: Add Panel auo kd101n80-45na support.
......................................................................

google/krane: Add Panel auo kd101n80-45na support.

Add panel kd101n80-45na driver for Krane.

BUG=b:129299873
BRANCH=none

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/display.h
M src/mainboard/google/kukui/panel_krane.c
2 files changed, 32 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/2

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: google/krane: Add Panel auo kd101n80-45na support.
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33413/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33413/2//COMMIT_MSG@7 
PS2, Line 7: google/krane: Add Panel auo kd101n80-45na support.
Please remove the dot/period at the end of the commit message summary.

[Nicolas Boichat (Code Review)]

Nicolas Boichat has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: google/krane: Add Panel auo kd101n80-45na support.
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... 
PS2, Line 381: 			((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf);
This is wrong. Also, this is fragile as you don't specify the ID exact value in the enum.

Please do this instead:

switch (sku_id() >> KRANE_PANEL_ID_BIT_POSITION) {
case 0x0:
    return PANEL_KRANE_AUO_KD101N80_45NA;
case 0x1: /* Incorrect strapping for BOE on rev3 */
case 0xb:
    return PANEL_KRANE_BOE_TV101WUM_NL6;
default:
    return PANEL_KRANE_UNKNOWN;
}

Change in ...coreboot[master]: google/krane: Add Panel auo kd101n80-45na support

[jitao shi (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33413

to look at the new patch set (#3).

Change subject: google/krane: Add Panel auo kd101n80-45na support
......................................................................

google/krane: Add Panel auo kd101n80-45na support

Add panel kd101n80-45na driver for Krane.

BUG=b:129299873
BRANCH=none

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/display.h
M src/mainboard/google/kukui/panel_krane.c
2 files changed, 39 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/3

Change in ...coreboot[master]: google/krane: Add Panel auo kd101n80-45na support

[jitao shi (Code Review)]

jitao shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: google/krane: Add Panel auo kd101n80-45na support
......................................................................

Patch Set 3:

(2 comments)

https://review.coreboot.org/#/c/33413/2//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33413/2//COMMIT_MSG@7 
PS2, Line 7: google/krane: Add Panel auo kd101n80-45na support.
> Please remove the dot/period at the end of the commit message summary.

Done

https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... 
PS2, Line 381: 			((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf);
> This is wrong. Also, this is fragile as you don't specify the ID exact value in the enum. […]

Done

Change in ...coreboot[master]: google/krane: Add Panel auo kd101n80-45na support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: google/krane: Add Panel auo kd101n80-45na support
......................................................................

Patch Set 3:

(2 comments)

Is a data sheet available for this panel?

https://review.coreboot.org/#/c/33413/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/33413/3//COMMIT_MSG@7 
PS3, Line 7: google/krane: Add Panel auo kd101n80-45na support
Add panel AUO kd101n80-45na support

https://review.coreboot.org/#/c/33413/3/src/mainboard/google/kukui/display.h 
File src/mainboard/google/kukui/display.h:

https://review.coreboot.org/#/c/33413/3/src/mainboard/google/kukui/display.h... 
PS3, Line 362: 
Please add a space after the first curly bracket {.

Change in coreboot[master]: google/krane: Add panel auo kd101n80-45na support

[jitao shi (Code Review)]

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/33413

to look at the new patch set (#4).

Change subject: google/krane: Add panel auo kd101n80-45na support
......................................................................

google/krane: Add panel auo kd101n80-45na support

Add panel auo kd101n80-45na driver for Krane.

BUG=b:129299873
BRANCH=none

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/display.h
M src/mainboard/google/kukui/panel_krane.c
2 files changed, 39 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/4

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#5) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 368 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/5

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#6) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 368 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/6

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#7) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/7

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#9) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/9

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Peichao Li (Code Review)]

Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33413/9/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/9/src/mainboard/google/kukui/... 
PS9, Line 44: boe_tv101wum_nl6
Hi Jitao,  this panel model is TV101WUM-NL6, correct? Thanks a lot!

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#11) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/11

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 15:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 36: INIT_DCS_CMD, 1, {0x11}
Not super happy about having to match the size here manually. Can we make wrapper macros for that? You could do something like

#define INIT_DCS_CMD(...) _LCM_CMD(INIT_DCS_OPCODE, __VA_ARGS__, 2, 1, 0)
 #define _LCM_CMD(opcode, arg0, arg1, NARGS, ...) \
   {opcode, NARGS, { _FILL_ARGS_##NARGS(arg0, arg1) }
 #define _FILL_ARGS_2(arg0, arg1) arg0, arg1
 #define _FILL_ARGS_1(arg0, arg1) arg0
 #define _FILL_ARGS_0(arg0, arg1)

(Can be expanded as needed, obviously.)

Alternatively, if we only need to support a relatively small amount of sizes per command, it might be easier to just have a different opcode for each size (e.g. INIT_DSC1(byte), INIT_DSC2(byte0, byte1), etc.).

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 357: static struct panel_description *krane_panels[] = {
We should split these into a separate CBFS file each like we have for SDRAM params. That way you don't need to load the super long one on boards that don't need it (and it will just get more important the more you add).

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 15:

(4 comments)

https://review.coreboot.org/c/coreboot/+/33413/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33413/3//COMMIT_MSG@7 
PS3, Line 7: google/krane: Add Panel auo kd101n80-45na support
> Add panel AUO kd101n80-45na support

Ack

https://review.coreboot.org/c/coreboot/+/33413/9/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/9/src/mainboard/google/kukui/... 
PS9, Line 44: boe_tv101wum_nl6
> Hi Jitao,  this panel model is TV101WUM-NL6, correct? Thanks a lot!

Ack

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 36: INIT_DCS_CMD, 1, {0x11}
> Not super happy about having to match the size here manually. […]

Done

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 357: static struct panel_description *krane_panels[] = {
> We should split these into a separate CBFS file each like we have for SDRAM params. […]

let's do that later when we find this really needed.
for now most boards will only have 2 panels that I think putting them into CBFS is not a high priority thing...

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#16) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/16

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 16:

there seems to be a gerrit error? I can't find/ack/reply to the comment on PS3.

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 16:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 357: static struct panel_description *krane_panels[] = {
> let's do that later when we find this really needed. […]

I did some experiment and found it not being very easy/clean at the moment.

The major reason is to load from CBFS we have to know the size first. SDRAM_config is usually in fixed size (or at least knowing the maximum). The table above may vary a lot and hard to define a size for it.

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 16: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/33413/16//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33413/16//COMMIT_MSG@9 
PS16, Line 9: following
the following

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 20: Code-Review+1

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#22) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/22

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#24) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/24

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#25) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 369 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/25

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 25: Code-Review+1

(1 comment)

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 357: static struct panel_description *krane_panels[] = {
> I did some experiment and found it not being very easy/clean at the moment. […]

Well... even with 8 byte per command some of your panels take up multiple KB right now. I think it would quickly become worth it. But I think it's okay to check these in like this and then do that later (if you hopefully still have time).

For loading, just allocate a big buffer that can easily hold your biggest panel. BSS is (relatively) cheap. It should just need something like

struct panel_description *get_panel_description(int panel_id)
 {
   char filename[64];
   static u8 buffer[4*KiB];
   /* ...maybe cache result if you want to call this more than once... */
   if (!snprintf(filename, sizeof(filename), "panel-description-%d",
                 panel_id) ||
       !cbfs_boot_load_file(filename, buffer, sizeof(buffer),
                            CBFS_TYPE_STRUCT))
     return NULL;
   return (struct panel_description *)buffer;
 }

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 26:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
File src/mainboard/google/kukui/panel_krane.c:

https://review.coreboot.org/c/coreboot/+/33413/15/src/mainboard/google/kukui... 
PS15, Line 357: static struct panel_description *krane_panels[] = {
> Well... even with 8 byte per command some of your panels take up multiple KB right now. […]

ok, let me add a  todo for it.

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#27) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 370 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/27

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#28) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 370 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/28

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#31) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 370 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/31

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#34) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 370 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/34

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#40) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 372 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/40

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 41: Code-Review+2

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#47) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 372 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/47

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#48) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 372 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/48

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 49: Code-Review+2

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Hung-Te Lin (Code Review)]

Hung-Te Lin has uploaded a new patch set (#51) to the change originally created by jitao shi. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 372 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/33413/51

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

Patch Set 51:

(2 comments)

https://review.coreboot.org/c/coreboot/+/33413/16//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/33413/16//COMMIT_MSG@9 
PS16, Line 9: following
> the following

Obsolete

https://review.coreboot.org/c/coreboot/+/33413/3/src/mainboard/google/kukui/... 
File src/mainboard/google/kukui/display.h:

https://review.coreboot.org/c/coreboot/+/33413/3/src/mainboard/google/kukui/... 
PS3, Line 362:
> Please add a space after the first curly bracket {.

Obsolete

Change in coreboot[master]: mb/google/kukui: Add panels for Krane

[Julius Werner (Code Review)]

Julius Werner has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33413 )

Change subject: mb/google/kukui: Add panels for Krane
......................................................................

mb/google/kukui: Add panels for Krane

Declare the following panels for Krane:
- BOE TV101WUM-NL6
- AUO KD101N80-45NA

The edid info and init command are from:
https://crrev.com/c/1565758

BUG=b:129299873
BRANCH=none
TEST=Builds krane image and boots properly.

Change-Id: Id19c6c2b4c1c728c39aa26301adf7d6fb5046403
Signed-off-by: Jitao Shi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33413
Tested-by: build bot (Jenkins) 
Reviewed-by: Julius Werner 
---
M src/mainboard/google/kukui/Makefile.inc
A src/mainboard/google/kukui/panel_krane.c
2 files changed, 372 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Julius Werner: Looks good to me, approved

diff --git a/src/mainboard/google/kukui/Makefile.inc b/src/mainboard/google/kukui/Makefile.inc
index a0556c1..554be69 100644
--- a/src/mainboard/google/kukui/Makefile.inc
+++ b/src/mainboard/google/kukui/Makefile.inc
@@ -24,4 +24,5 @@
 ramstage-y += chromeos.c
 ramstage-y += mainboard.c
 ramstage-y += memlayout.ld
+ramstage-$(CONFIG_BOARD_GOOGLE_KRANE) += panel_krane.c
 ramstage-y += reset.c
diff --git a/src/mainboard/google/kukui/panel_krane.c b/src/mainboard/google/kukui/panel_krane.c
new file mode 100644
index 0000000..ad06f39
--- /dev/null
+++ b/src/mainboard/google/kukui/panel_krane.c
@@ -0,0 +1,371 @@
+/*
+ * This file is part of the coreboot project.
+ *
+ * Copyright 2019 Huaqin Telecom Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ */
+
+#include "panel.h"
+
+static struct panel_description AUO_KD101N80_45NA = {
+	.edid = {
+		.ascii_string = "KD101N80-45NA",
+		.panel_bits_per_color = 8,
+		.panel_bits_per_pixel = 24,
+		.mode = {
+			.name = "1200x1920@60Hz",
+			.pixel_clock = 157000,
+			.lvds_dual_channel = 0,
+			.refresh = 60,
+			.ha = 1200, .hbl = 140, .hso = 80, .hspw = 24,
+			.va = 1920, .vbl = 36, .vso = 16, .vspw = 4,
+			.phsync = '-', .pvsync = '-',
+			.x_mm = 135, .y_mm = 216,
+		},
+	},
+	.orientation = LB_FB_ORIENTATION_LEFT_UP,
+	.init = {
+		INIT_DELAY_CMD(10),
+		INIT_DCS_CMD(0x11),
+		INIT_DELAY_CMD(120),
+		INIT_DCS_CMD(0x29),
+		INIT_DELAY_CMD(20),
+		INIT_END_CMD,
+	},
+};
+
+static struct panel_description BOE_TV101WUM_NL6 = {
+	.edid = {
+		.ascii_string = "TV101WUM-NL6",
+		.panel_bits_per_color = 8,
+		.panel_bits_per_pixel = 24,
+		.mode = {
+			.name = "1200x1920@60Hz",
+			.pixel_clock = 159425,
+			.lvds_dual_channel = 0,
+			.refresh = 60,
+			.ha = 1200, .hbl = 164, .hso = 100, .hspw = 24,
+			.va = 1920, .vbl = 28, .vso = 10, .vspw = 4,
+			.phsync = '-', .pvsync = '-',
+			.x_mm = 135, .y_mm = 216,
+		},
+	},
+	.orientation = LB_FB_ORIENTATION_LEFT_UP,
+	.init = {
+		INIT_DELAY_CMD(24),
+		INIT_DCS_CMD(0xB0, 0x05),
+		INIT_DCS_CMD(0xB1, 0xE5),
+		INIT_DCS_CMD(0xB3, 0x52),
+		INIT_DCS_CMD(0xB0, 0x00),
+		INIT_DCS_CMD(0xB3, 0x88),
+		INIT_DCS_CMD(0xB0, 0x04),
+		INIT_DCS_CMD(0xB8, 0x00),
+		INIT_DCS_CMD(0xB0, 0x00),
+		INIT_DCS_CMD(0xB6, 0x03),
+		INIT_DCS_CMD(0xBA, 0x8B),
+		INIT_DCS_CMD(0xBF, 0x1A),
+		INIT_DCS_CMD(0xC0, 0x0F),
+		INIT_DCS_CMD(0xC2, 0x0C),
+		INIT_DCS_CMD(0xC3, 0x02),
+		INIT_DCS_CMD(0xC4, 0x0C),
+		INIT_DCS_CMD(0xC5, 0x02),
+		INIT_DCS_CMD(0xB0, 0x01),
+		INIT_DCS_CMD(0xE0, 0x26),
+		INIT_DCS_CMD(0xE1, 0x26),
+		INIT_DCS_CMD(0xDC, 0x00),
+		INIT_DCS_CMD(0xDD, 0x00),
+		INIT_DCS_CMD(0xCC, 0x26),
+		INIT_DCS_CMD(0xCD, 0x26),
+		INIT_DCS_CMD(0xC8, 0x00),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xD2, 0x03),
+		INIT_DCS_CMD(0xD3, 0x03),
+		INIT_DCS_CMD(0xE6, 0x04),
+		INIT_DCS_CMD(0xE7, 0x04),
+		INIT_DCS_CMD(0xC4, 0x09),
+		INIT_DCS_CMD(0xC5, 0x09),
+		INIT_DCS_CMD(0xD8, 0x0A),
+		INIT_DCS_CMD(0xD9, 0x0A),
+		INIT_DCS_CMD(0xC2, 0x0B),
+		INIT_DCS_CMD(0xC3, 0x0B),
+		INIT_DCS_CMD(0xD6, 0x0C),
+		INIT_DCS_CMD(0xD7, 0x0C),
+		INIT_DCS_CMD(0xC0, 0x05),
+		INIT_DCS_CMD(0xC1, 0x05),
+		INIT_DCS_CMD(0xD4, 0x06),
+		INIT_DCS_CMD(0xD5, 0x06),
+		INIT_DCS_CMD(0xCA, 0x07),
+		INIT_DCS_CMD(0xCB, 0x07),
+		INIT_DCS_CMD(0xDE, 0x08),
+		INIT_DCS_CMD(0xDF, 0x08),
+		INIT_DCS_CMD(0xB0, 0x02),
+		INIT_DCS_CMD(0xC0, 0x00),
+		INIT_DCS_CMD(0xC1, 0x0D),
+		INIT_DCS_CMD(0xC2, 0x17),
+		INIT_DCS_CMD(0xC3, 0x26),
+		INIT_DCS_CMD(0xC4, 0x31),
+		INIT_DCS_CMD(0xC5, 0x1C),
+		INIT_DCS_CMD(0xC6, 0x2C),
+		INIT_DCS_CMD(0xC7, 0x33),
+		INIT_DCS_CMD(0xC8, 0x31),
+		INIT_DCS_CMD(0xC9, 0x37),
+		INIT_DCS_CMD(0xCA, 0x37),
+		INIT_DCS_CMD(0xCB, 0x37),
+		INIT_DCS_CMD(0xCC, 0x39),
+		INIT_DCS_CMD(0xCD, 0x2E),
+		INIT_DCS_CMD(0xCE, 0x2F),
+		INIT_DCS_CMD(0xCF, 0x2F),
+		INIT_DCS_CMD(0xD0, 0x07),
+		INIT_DCS_CMD(0xD2, 0x00),
+		INIT_DCS_CMD(0xD3, 0x0D),
+		INIT_DCS_CMD(0xD4, 0x17),
+		INIT_DCS_CMD(0xD5, 0x26),
+		INIT_DCS_CMD(0xD6, 0x31),
+		INIT_DCS_CMD(0xD7, 0x3F),
+		INIT_DCS_CMD(0xD8, 0x3F),
+		INIT_DCS_CMD(0xD9, 0x3F),
+		INIT_DCS_CMD(0xDA, 0x3F),
+		INIT_DCS_CMD(0xDB, 0x37),
+		INIT_DCS_CMD(0xDC, 0x37),
+		INIT_DCS_CMD(0xDD, 0x37),
+		INIT_DCS_CMD(0xDE, 0x39),
+		INIT_DCS_CMD(0xDF, 0x2E),
+		INIT_DCS_CMD(0xE0, 0x2F),
+		INIT_DCS_CMD(0xE1, 0x2F),
+		INIT_DCS_CMD(0xE2, 0x07),
+		INIT_DCS_CMD(0xB0, 0x03),
+		INIT_DCS_CMD(0xC8, 0x0B),
+		INIT_DCS_CMD(0xC9, 0x07),
+		INIT_DCS_CMD(0xC3, 0x00),
+		INIT_DCS_CMD(0xE7, 0x00),
+		INIT_DCS_CMD(0xC5, 0x2A),
+		INIT_DCS_CMD(0xDE, 0x2A),
+		INIT_DCS_CMD(0xCA, 0x43),
+		INIT_DCS_CMD(0xC9, 0x07),
+		INIT_DCS_CMD(0xE4, 0xC0),
+		INIT_DCS_CMD(0xE5, 0x0D),
+		INIT_DCS_CMD(0xCB, 0x00),
+		INIT_DCS_CMD(0xB0, 0x06),
+		INIT_DCS_CMD(0xB8, 0xA5),
+		INIT_DCS_CMD(0xC0, 0xA5),
+		INIT_DCS_CMD(0xC7, 0x0F),
+		INIT_DCS_CMD(0xD5, 0x32),
+		INIT_DCS_CMD(0xB8, 0x00),
+		INIT_DCS_CMD(0xC0, 0x00),
+		INIT_DCS_CMD(0xBC, 0x00),
+		INIT_DCS_CMD(0xB0, 0x07),
+		INIT_DCS_CMD(0xB1, 0x00),
+		INIT_DCS_CMD(0xB2, 0x02),
+		INIT_DCS_CMD(0xB3, 0x0F),
+		INIT_DCS_CMD(0xB4, 0x25),
+		INIT_DCS_CMD(0xB5, 0x39),
+		INIT_DCS_CMD(0xB6, 0x4E),
+		INIT_DCS_CMD(0xB7, 0x72),
+		INIT_DCS_CMD(0xB8, 0x97),
+		INIT_DCS_CMD(0xB9, 0xDC),
+		INIT_DCS_CMD(0xBA, 0x22),
+		INIT_DCS_CMD(0xBB, 0xA4),
+		INIT_DCS_CMD(0xBC, 0x2B),
+		INIT_DCS_CMD(0xBD, 0x2F),
+		INIT_DCS_CMD(0xBE, 0xA9),
+		INIT_DCS_CMD(0xBF, 0x25),
+		INIT_DCS_CMD(0xC0, 0x61),
+		INIT_DCS_CMD(0xC1, 0x97),
+		INIT_DCS_CMD(0xC2, 0xB2),
+		INIT_DCS_CMD(0xC3, 0xCD),
+		INIT_DCS_CMD(0xC4, 0xD9),
+		INIT_DCS_CMD(0xC5, 0xE7),
+		INIT_DCS_CMD(0xC6, 0xF4),
+		INIT_DCS_CMD(0xC7, 0xFA),
+		INIT_DCS_CMD(0xC8, 0xFC),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xCA, 0x00),
+		INIT_DCS_CMD(0xCB, 0x16),
+		INIT_DCS_CMD(0xCC, 0xAF),
+		INIT_DCS_CMD(0xCD, 0xFF),
+		INIT_DCS_CMD(0xCE, 0xFF),
+		INIT_DCS_CMD(0xB0, 0x08),
+		INIT_DCS_CMD(0xB1, 0x04),
+		INIT_DCS_CMD(0xB2, 0x05),
+		INIT_DCS_CMD(0xB3, 0x11),
+		INIT_DCS_CMD(0xB4, 0x24),
+		INIT_DCS_CMD(0xB5, 0x39),
+		INIT_DCS_CMD(0xB6, 0x4F),
+		INIT_DCS_CMD(0xB7, 0x72),
+		INIT_DCS_CMD(0xB8, 0x98),
+		INIT_DCS_CMD(0xB9, 0xDC),
+		INIT_DCS_CMD(0xBA, 0x23),
+		INIT_DCS_CMD(0xBB, 0xA6),
+		INIT_DCS_CMD(0xBC, 0x2C),
+		INIT_DCS_CMD(0xBD, 0x30),
+		INIT_DCS_CMD(0xBE, 0xAA),
+		INIT_DCS_CMD(0xBF, 0x26),
+		INIT_DCS_CMD(0xC0, 0x62),
+		INIT_DCS_CMD(0xC1, 0x9B),
+		INIT_DCS_CMD(0xC2, 0xB5),
+		INIT_DCS_CMD(0xC3, 0xCF),
+		INIT_DCS_CMD(0xC4, 0xDB),
+		INIT_DCS_CMD(0xC5, 0xE8),
+		INIT_DCS_CMD(0xC6, 0xF5),
+		INIT_DCS_CMD(0xC7, 0xFA),
+		INIT_DCS_CMD(0xC8, 0xFC),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xCA, 0x00),
+		INIT_DCS_CMD(0xCB, 0x16),
+		INIT_DCS_CMD(0xCC, 0xAF),
+		INIT_DCS_CMD(0xCD, 0xFF),
+		INIT_DCS_CMD(0xCE, 0xFF),
+		INIT_DCS_CMD(0xB0, 0x09),
+		INIT_DCS_CMD(0xB1, 0x04),
+		INIT_DCS_CMD(0xB2, 0x02),
+		INIT_DCS_CMD(0xB3, 0x16),
+		INIT_DCS_CMD(0xB4, 0x24),
+		INIT_DCS_CMD(0xB5, 0x3B),
+		INIT_DCS_CMD(0xB6, 0x4F),
+		INIT_DCS_CMD(0xB7, 0x73),
+		INIT_DCS_CMD(0xB8, 0x99),
+		INIT_DCS_CMD(0xB9, 0xE0),
+		INIT_DCS_CMD(0xBA, 0x26),
+		INIT_DCS_CMD(0xBB, 0xAD),
+		INIT_DCS_CMD(0xBC, 0x36),
+		INIT_DCS_CMD(0xBD, 0x3A),
+		INIT_DCS_CMD(0xBE, 0xAE),
+		INIT_DCS_CMD(0xBF, 0x2A),
+		INIT_DCS_CMD(0xC0, 0x66),
+		INIT_DCS_CMD(0xC1, 0x9E),
+		INIT_DCS_CMD(0xC2, 0xB8),
+		INIT_DCS_CMD(0xC3, 0xD1),
+		INIT_DCS_CMD(0xC4, 0xDD),
+		INIT_DCS_CMD(0xC5, 0xE9),
+		INIT_DCS_CMD(0xC6, 0xF6),
+		INIT_DCS_CMD(0xC7, 0xFA),
+		INIT_DCS_CMD(0xC8, 0xFC),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xCA, 0x00),
+		INIT_DCS_CMD(0xCB, 0x16),
+		INIT_DCS_CMD(0xCC, 0xAF),
+		INIT_DCS_CMD(0xCD, 0xFF),
+		INIT_DCS_CMD(0xCE, 0xFF),
+		INIT_DCS_CMD(0xB0, 0x0A),
+		INIT_DCS_CMD(0xB1, 0x00),
+		INIT_DCS_CMD(0xB2, 0x02),
+		INIT_DCS_CMD(0xB3, 0x0F),
+		INIT_DCS_CMD(0xB4, 0x25),
+		INIT_DCS_CMD(0xB5, 0x39),
+		INIT_DCS_CMD(0xB6, 0x4E),
+		INIT_DCS_CMD(0xB7, 0x72),
+		INIT_DCS_CMD(0xB8, 0x97),
+		INIT_DCS_CMD(0xB9, 0xDC),
+		INIT_DCS_CMD(0xBA, 0x22),
+		INIT_DCS_CMD(0xBB, 0xA4),
+		INIT_DCS_CMD(0xBC, 0x2B),
+		INIT_DCS_CMD(0xBD, 0x2F),
+		INIT_DCS_CMD(0xBE, 0xA9),
+		INIT_DCS_CMD(0xBF, 0x25),
+		INIT_DCS_CMD(0xC0, 0x61),
+		INIT_DCS_CMD(0xC1, 0x97),
+		INIT_DCS_CMD(0xC2, 0xB2),
+		INIT_DCS_CMD(0xC3, 0xCD),
+		INIT_DCS_CMD(0xC4, 0xD9),
+		INIT_DCS_CMD(0xC5, 0xE7),
+		INIT_DCS_CMD(0xC6, 0xF4),
+		INIT_DCS_CMD(0xC7, 0xFA),
+		INIT_DCS_CMD(0xC8, 0xFC),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xCA, 0x00),
+		INIT_DCS_CMD(0xCB, 0x16),
+		INIT_DCS_CMD(0xCC, 0xAF),
+		INIT_DCS_CMD(0xCD, 0xFF),
+		INIT_DCS_CMD(0xCE, 0xFF),
+		INIT_DCS_CMD(0xB0, 0x0B),
+		INIT_DCS_CMD(0xB1, 0x04),
+		INIT_DCS_CMD(0xB2, 0x05),
+		INIT_DCS_CMD(0xB3, 0x11),
+		INIT_DCS_CMD(0xB4, 0x24),
+		INIT_DCS_CMD(0xB5, 0x39),
+		INIT_DCS_CMD(0xB6, 0x4F),
+		INIT_DCS_CMD(0xB7, 0x72),
+		INIT_DCS_CMD(0xB8, 0x98),
+		INIT_DCS_CMD(0xB9, 0xDC),
+		INIT_DCS_CMD(0xBA, 0x23),
+		INIT_DCS_CMD(0xBB, 0xA6),
+		INIT_DCS_CMD(0xBC, 0x2C),
+		INIT_DCS_CMD(0xBD, 0x30),
+		INIT_DCS_CMD(0xBE, 0xAA),
+		INIT_DCS_CMD(0xBF, 0x26),
+		INIT_DCS_CMD(0xC0, 0x62),
+		INIT_DCS_CMD(0xC1, 0x9B),
+		INIT_DCS_CMD(0xC2, 0xB5),
+		INIT_DCS_CMD(0xC3, 0xCF),
+		INIT_DCS_CMD(0xC4, 0xDB),
+		INIT_DCS_CMD(0xC5, 0xE8),
+		INIT_DCS_CMD(0xC6, 0xF5),
+		INIT_DCS_CMD(0xC7, 0xFA),
+		INIT_DCS_CMD(0xC8, 0xFC),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xCA, 0x00),
+		INIT_DCS_CMD(0xCB, 0x16),
+		INIT_DCS_CMD(0xCC, 0xAF),
+		INIT_DCS_CMD(0xCD, 0xFF),
+		INIT_DCS_CMD(0xCE, 0xFF),
+		INIT_DCS_CMD(0xB0, 0x0C),
+		INIT_DCS_CMD(0xB1, 0x04),
+		INIT_DCS_CMD(0xB2, 0x02),
+		INIT_DCS_CMD(0xB3, 0x16),
+		INIT_DCS_CMD(0xB4, 0x24),
+		INIT_DCS_CMD(0xB5, 0x3B),
+		INIT_DCS_CMD(0xB6, 0x4F),
+		INIT_DCS_CMD(0xB7, 0x73),
+		INIT_DCS_CMD(0xB8, 0x99),
+		INIT_DCS_CMD(0xB9, 0xE0),
+		INIT_DCS_CMD(0xBA, 0x26),
+		INIT_DCS_CMD(0xBB, 0xAD),
+		INIT_DCS_CMD(0xBC, 0x36),
+		INIT_DCS_CMD(0xBD, 0x3A),
+		INIT_DCS_CMD(0xBE, 0xAE),
+		INIT_DCS_CMD(0xBF, 0x2A),
+		INIT_DCS_CMD(0xC0, 0x66),
+		INIT_DCS_CMD(0xC1, 0x9E),
+		INIT_DCS_CMD(0xC2, 0xB8),
+		INIT_DCS_CMD(0xC3, 0xD1),
+		INIT_DCS_CMD(0xC4, 0xDD),
+		INIT_DCS_CMD(0xC5, 0xE9),
+		INIT_DCS_CMD(0xC6, 0xF6),
+		INIT_DCS_CMD(0xC7, 0xFA),
+		INIT_DCS_CMD(0xC8, 0xFC),
+		INIT_DCS_CMD(0xC9, 0x00),
+		INIT_DCS_CMD(0xCA, 0x00),
+		INIT_DCS_CMD(0xCB, 0x16),
+		INIT_DCS_CMD(0xCC, 0xAF),
+		INIT_DCS_CMD(0xCD, 0xFF),
+		INIT_DCS_CMD(0xCE, 0xFF),
+		INIT_DCS_CMD(0xB0, 0x00),
+		INIT_DCS_CMD(0xB3, 0x08),
+		INIT_DCS_CMD(0xB0, 0x04),
+		INIT_DCS_CMD(0xB8, 0x68),
+		INIT_DELAY_CMD(150),
+		INIT_END_CMD,
+	},
+};
+
+static struct panel_description *krane_panels[] = {
+	[0] = &AUO_KD101N80_45NA,
+	[1] = &BOE_TV101WUM_NL6,  /* Only for Rev 3 units, can be reused. */
+	[11] = &BOE_TV101WUM_NL6,
+};
+
+struct panel_description *get_panel_description(int panel_id)
+{
+	/* TODO(hungte): Move the configs into CBFS and load dynamically. */
+	if (panel_id < 0 || panel_id >= ARRAY_SIZE(krane_panels))
+		return NULL;
+	return krane_panels[panel_id];
+}