jitao shi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33413 )
Change subject: google/krane: Add Panel auo kd101n80-45na support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33413/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/33413/2//COMMIT_MSG@7 PS2, Line 7: google/krane: Add Panel auo kd101n80-45na support.
Please remove the dot/period at the end of the commit message summary.
Done
https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... File src/mainboard/google/kukui/panel_krane.c:
https://review.coreboot.org/#/c/33413/2/src/mainboard/google/kukui/panel_kra... PS2, Line 381: ((sku_id() >> KRANE_PANEL_ID_BIT_POSITION) & 0xf);
This is wrong. Also, this is fragile as you don't specify the ID exact value in the enum. […]
Done