build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71608 )
Change subject: mb/hp/t620: Add clone of biostar/a68n-5200 ......................................................................
Patch Set 1:
(13 comments)
File src/mainboard/hp/t620/BiosCallOuts.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/06edbb8d_468065ec PS1, Line 11: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/563dc4f4_8948154e PS1, Line 45: { that open brace { should be on the previous line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/9b08aa43_f2580f15 PS1, Line 46: {0x10ec0272, (CODEC_ENTRY*)&Olivehill_Alc272_VerbTbl[0]}, "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/84941c55_311018c2 PS1, Line 47: {(UINT32)0x0FFFFFFFF, (CODEC_ENTRY*)0x0FFFFFFFFUL} "(foo*)" should be "(foo *)"
File src/mainboard/hp/t620/OemCustomize.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/604632cb_ebf3b780 PS1, Line 118: NUMBER_OF_DIMMS_SUPPORTED(ANY_SOCKET, ANY_CHANNEL, 2), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/1a0b2ce7_a4f5e573 PS1, Line 119: NUMBER_OF_CHANNELS_SUPPORTED(ANY_SOCKET, 1), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/2a3a8605_2d90c5d8 PS1, Line 120: MOTHER_BOARD_LAYERS(LAYERS_4), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/f33010bd_80927217 PS1, Line 122: MEMCLK_DIS_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x04, 0x08, 0x00, 0x00, 0x00, 0x00), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/30e4ebf9_b854cce8 PS1, Line 123: CKE_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x04, 0x08), /* TODO: bit2map, bit3map */ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/bdad75f8_9a9f7fd1 PS1, Line 124: ODT_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x04, 0x08), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/4cdb037c_0e074be0 PS1, Line 125: CS_TRI_MAP(ANY_SOCKET, ANY_CHANNEL, 0x01, 0x02, 0x04, 0x08, 0x00, 0x00, 0x00, 0x00), please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/6ad023f3_9a3608a0 PS1, Line 127: PSO_END please, no spaces at the start of a line
File src/mainboard/hp/t620/irq_tables.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-167482): https://review.coreboot.org/c/coreboot/+/71608/comment/75846232_6557eb3b PS1, Line 81: if (sum != pirq->checksum) { braces {} are not necessary for single statement blocks
-
build bot (Jenkins) (Code Review)