Change in ...coreboot[master]: mb/google/sarien: Add support for melfas touch panel

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

EricR Lai (Code Review)

3 Apr 2019 3 Apr '19

9:02 a.m.

EricR Lai has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32169

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

mb/google/sarien: Add support for melfas touch panel

According to b/122019253#comment44, add a support melfas touch panel with i2c address 0x34.

BUG=b:122019253 TEST=tested with new melfas touch panel and worked

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/32169/1

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index 72dea1e..f3cd829 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -332,6 +332,16 @@ register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end + chip drivers/i2c/generic + register "hid" = ""MLFS0000"" + register "desc" = ""Melfas Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" + register "probed" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" + register "enable_delay_ms" = "5" + register "has_power_resource" = "1" + device i2c 34 on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic

Attachments:

attachment.htm (text/html — 3.6 KB)

Show replies by date

Furquan Shaikh (Code Review)

3 Apr 3 Apr

3:13 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32169 )

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32169/1/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/sarien/devicetree.cb:

https://review.coreboot.org/#/c/32169/1/src/mainboard/google/sarien/variants... PS1, Line 335: generic Doesn't this use hid driver?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 03 Apr 2019 15:13:05 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Paul Menzel (Code Review)

3:21 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32169 )

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

Patch Set 1:

(3 comments)

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG@9 PS1, Line 9: b/122019253 Use colon (:)?

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG@9 PS1, Line 9: add a support Remove the article.

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG@9 PS1, Line 9: According to b/122019253#comment44, add a support : melfas touch panel with i2c address 0x34. Please use the full the text width.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Wed, 03 Apr 2019 15:21:37 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

EricR Lai (Code Review)

4 Apr 4 Apr

3:09 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32169 )

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/32169/1/src/mainboard/google/sarien/variants... File src/mainboard/google/sarien/variants/sarien/devicetree.cb:

https://review.coreboot.org/#/c/32169/1/src/mainboard/google/sarien/variants... PS1, Line 335: generic

...

Doesn't this use hid driver?

they decide to change to I2C for performance tuning issue. They can't pass AVL with HID.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 1 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 04 Apr 2019 03:09:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Furquan Shaikh furquan@google.com Gerrit-MessageType: comment

EricR Lai (Code Review)

3:10 a.m.

Hello Duncan Laurie, build bot (Jenkins), Furquan Shaikh,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32169

to look at the new patch set (#2).

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

mb/google/sarien: Add support for melfas touch panel

Add a support melfas touch panel with i2c address:0x34.

BUG=b:122019253 TEST=tested with new melfas touch panel and worked

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/32169/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-MessageType: newpatchset

EricR Lai (Code Review)

3:11 a.m.

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32169 )

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

Patch Set 2:

(3 comments)

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG@9 PS1, Line 9: add a support

...

Remove the article.

Done

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG@9 PS1, Line 9: b/122019253

...

Use colon (:)?

Done

https://review.coreboot.org/#/c/32169/1//COMMIT_MSG@9 PS1, Line 9: According to b/122019253#comment44, add a support : melfas touch panel with i2c address 0x34.

...

Please use the full the text width.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 04 Apr 2019 03:11:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:52 a.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32169 )

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 2 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-Comment-Date: Thu, 04 Apr 2019 05:52:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

8 Apr 8 Apr

2:09 p.m.

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32169 )

Change subject: mb/google/sarien: Add support for melfas touch panel ......................................................................

mb/google/sarien: Add support for melfas touch panel

Add a support melfas touch panel with i2c address:0x34.

BUG=b:122019253 TEST=tested with new melfas touch panel and worked

Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Reviewed-on: https://review.coreboot.org/c/coreboot/+/32169 Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 10 insertions(+), 0 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved

diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index caae79f..f04149f 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -332,6 +332,16 @@ register "hid_desc_reg_offset" = "0x01" device i2c 10 on end end + chip drivers/i2c/generic + register "hid" = ""MLFS0000"" + register "desc" = ""Melfas Touchscreen"" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" + register "probed" = "1" + register "enable_gpio" = "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" + register "enable_delay_ms" = "5" + register "has_power_resource" = "1" + device i2c 34 on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic

-- To view, visit https://review.coreboot.org/c/coreboot/+/32169 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I27f5c47517d093c819cbbbcdafd85d74145887e1 Gerrit-Change-Number: 32169 Gerrit-PatchSet: 3 Gerrit-Owner: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org Gerrit-Reviewer: EricR Lai ericr_lai@compal.corp-partner.google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Chris Zhou chris_zhou@compal.corp-partner.google.com Gerrit-CC: Ivy Jian ivy_jian@compal.corp-partner.google.com Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-CC: Van Chen van_chen@compal.corp-partner.google.com Gerrit-MessageType: merged

2000

days inactive

2005

days old

coreboot-gerrit@coreboot.org

7 comments

4 participants

tags (0)

participants (4)

EricR Lai (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)