HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25601 )
Change subject: nb/intel/x4x: Use parallel MP init ......................................................................
Patch Set 37:
(2 comments)
https://review.coreboot.org/#/c/25601/37/src/cpu/intel/model_f4x/model_f4x_i... File src/cpu/intel/model_f4x/model_f4x_init.c:
https://review.coreboot.org/#/c/25601/37/src/cpu/intel/model_f4x/model_f4x_i... PS37, Line 16: #include <cpu/x86/mtrr.h> I think you can remove this include
https://review.coreboot.org/#/c/25601/37/src/cpu/intel/model_f4x/model_f4x_i... PS37, Line 18: #include <cpu/intel/microcode.h> : #include <cpu/intel/hyperthreading.h> here also