Attention is currently required from: Angel Pons, Felix Held, Fred Reitberger, Jason Glenesk, Marvin Drees, Matt DeVillier, Naresh Solanki.
Paul Menzel has posted comments on this change by Naresh Solanki. ( https://review.coreboot.org/c/coreboot/+/85640?usp=email )
Change subject: soc/amd/common/cpu/noncar: Compute core info
......................................................................
Patch Set 16:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85640/comment/3bf6d634_be570b39?usp... :
PS16, Line 7: Compute core info
It’d be great if you could be more specific.
https://review.coreboot.org/c/coreboot/+/85640/comment/bb0e1c90_618ada1e?usp... :
PS16, Line 9: In some SoC like Glinda, have
: 1. Different CPU cores have
*In some … have, … have* is confusing to me. It’d be great if you could rephrase it.
https://review.coreboot.org/c/coreboot/+/85640/comment/998ae708_4b27babf?usp... :
PS16, Line 13: function
function*s*
https://review.coreboot.org/c/coreboot/+/85640/comment/c0a22f19_85a9cb0c?usp... :
PS16, Line 19: Retrieves
Imperative mood: Retrieve
(also below)
https://review.coreboot.org/c/coreboot/+/85640/comment/43d05052_b16367d8?usp... :
PS16, Line 26: 24MB
What was it before?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85640?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I46947e8ac62c903036a81642e03201e353c3dac6
Gerrit-Change-Number: 85640
Gerrit-PatchSet: 16
Gerrit-Owner: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marvin Drees
marvin.drees@9elements.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Marvin Drees
marvin.drees@9elements.com
Gerrit-Attention: Naresh Solanki
naresh.solanki@9elements.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Sat, 12 Apr 2025 14:02:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No