Yu-Ping Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34192 )
Change subject: google/kukui: Modify LCM ID voltages ......................................................................
google/kukui: Modify LCM ID voltages
Currently some of the LCM ID voltage gaps are below 100mV. For example, the voltage difference between ID 2 and 3 is 503-440=63mV. To reduce the risk of misrecognition from the hardware lebel, the voltages are adjusted so that all the voltage gaps are larger than 100mV. The RD2 resistor values are also updated.
BUG=b:136987483 TEST=emerge-kukui coreboot
Change-Id: Ib5c1f927fb54d8c9579f030e42eeec5a27daaceb Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/boardid.c 1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/34192/1
diff --git a/src/mainboard/google/kukui/boardid.c b/src/mainboard/google/kukui/boardid.c index 71f051f..2bd79c5 100644 --- a/src/mainboard/google/kukui/boardid.c +++ b/src/mainboard/google/kukui/boardid.c @@ -51,15 +51,15 @@ /* ID : Voltage (unit: uV) */ /* 0 : */ 0, /* 1 : */ 283000, - /* 2 : */ 440000, + /* 2 : */ 394000, /* 3 : */ 503000, /* 4 : */ 608000, - /* 5 : */ 703000, - /* 6 : */ 830000, - /* 7 : */ 865000, - /* 8 : */ 953000, - /* 9 : */ 1079000, - /* 10 : */ 1128000, + /* 5 : */ 712000, + /* 6 : */ 823000, + /* 7 : */ 937000, + /* 8 : */ 1046000, + /* 9 : */ 1155000, + /* 10 : */ 1277000, /* 11 : */ 1434000, };
Hello Julius Werner, Tristan Hsieh, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34192
to look at the new patch set (#2).
Change subject: google/kukui: Adjust LCM ID voltages ......................................................................
google/kukui: Adjust LCM ID voltages
Currently some of the LCM ID voltage gaps are below 100mV. For example, the voltage difference between ID 2 and 3 is 503-440=63mV. To reduce the risk of misrecognition from the hardware level, the voltages are adjusted so that all the voltage gaps are larger than 100mV. The RD2 resistor values are also updated.
BUG=b:136987483 TEST=emerge-kukui coreboot
Change-Id: Ib5c1f927fb54d8c9579f030e42eeec5a27daaceb Signed-off-by: Yu-Ping Wu yupingso@google.com --- M src/mainboard/google/kukui/boardid.c 1 file changed, 7 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/92/34192/2
You-Cheng Syu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34192 )
Change subject: google/kukui: Adjust LCM ID voltages ......................................................................
Patch Set 2: Code-Review+1
Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34192 )
Change subject: google/kukui: Adjust LCM ID voltages ......................................................................
Patch Set 2: Code-Review+2
Martin Roth has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34192 )
Change subject: google/kukui: Adjust LCM ID voltages ......................................................................
google/kukui: Adjust LCM ID voltages
Currently some of the LCM ID voltage gaps are below 100mV. For example, the voltage difference between ID 2 and 3 is 503-440=63mV. To reduce the risk of misrecognition from the hardware level, the voltages are adjusted so that all the voltage gaps are larger than 100mV. The RD2 resistor values are also updated.
BUG=b:136987483 TEST=emerge-kukui coreboot
Change-Id: Ib5c1f927fb54d8c9579f030e42eeec5a27daaceb Signed-off-by: Yu-Ping Wu yupingso@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34192 Reviewed-by: You-Cheng Syu youcheng@google.com Reviewed-by: Hung-Te Lin hungte@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/kukui/boardid.c 1 file changed, 7 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Hung-Te Lin: Looks good to me, approved You-Cheng Syu: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/kukui/boardid.c b/src/mainboard/google/kukui/boardid.c index ad06666..ad7fb36 100644 --- a/src/mainboard/google/kukui/boardid.c +++ b/src/mainboard/google/kukui/boardid.c @@ -51,15 +51,15 @@ /* ID : Voltage (unit: uV) */ /* 0 : */ 0, /* 1 : */ 283000, - /* 2 : */ 440000, + /* 2 : */ 394000, /* 3 : */ 503000, /* 4 : */ 608000, - /* 5 : */ 703000, - /* 6 : */ 830000, - /* 7 : */ 865000, - /* 8 : */ 953000, - /* 9 : */ 1079000, - /* 10 : */ 1128000, + /* 5 : */ 712000, + /* 6 : */ 823000, + /* 7 : */ 937000, + /* 8 : */ 1046000, + /* 9 : */ 1155000, + /* 10 : */ 1277000, /* 11 : */ 1434000, };
-
Hung-Te Lin (Code Review) -
Martin Roth (Code Review)
-
You-Cheng Syu (Code Review)
-
Yu-Ping Wu (Code Review)