Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/29573 )
Change subject: soc/intel: Clean mess around UART_DEBUG ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/29573/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29573/1//COMMIT_MSG@10 PS1, Line 10: Based on Kconfig prompts the SoC code performed pad configu- : rations! Which chipset? And what exactly were the bad configurations?
https://review.coreboot.org/#/c/29573/1/src/soc/intel/common/block/uart/Kcon... File src/soc/intel/common/block/uart/Kconfig:
https://review.coreboot.org/#/c/29573/1/src/soc/intel/common/block/uart/Kcon... PS1, Line 20: bool We have 2 different builds with chromium. 1 with serial console and 1 w/o. By not making this option visible we can't select it with a local .config file.
-
Aaron Durbin (Code Review)