Change in ...coreboot[master]: mb/google/fizz/variants/karma: Clear GPP_B4 when entering S5
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29796 )
Change subject: mb/google/fizz/variants/karma: Clear GPP_B4 when entering S5 ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/29796/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/29796/2//COMMIT_MSG@11 PS2, Line 11: BUG=b:124197348 Linked bug has no details about why this is required. Also, the bug talks about suspend stress test which is using S3 and this change seems to affect only S5.
https://review.coreboot.org/#/c/29796/2/src/mainboard/google/fizz/variants/k... File src/mainboard/google/fizz/variants/karma/smihandler.c:
https://review.coreboot.org/#/c/29796/2/src/mainboard/google/fizz/variants/k... PS2, Line 24: ACPI_S5 Do you need this for S3 too?
-
Furquan Shaikh (Code Review)