Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63281 )
Change subject: util/spd_tools: Add ability to override SPD file for parts
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS3:
I think it might be better to leave it in place because it's a fairly minor change and I can imagine […]
i'd still say that CB:62905 was solving the wrong problem, but keeping that shouldn't be much of an issue apart from code complexity
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63281
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I078dd04fead2bf19f53bc6ca8295187d439adc20
Gerrit-Change-Number: 63281
Gerrit-PatchSet: 4
Gerrit-Owner: Robert Zieba
robertzieba@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Wed, 06 Apr 2022 19:55:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Robert Zieba
robertzieba@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment