build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25382 )
Change subject: soc/cavium: Apply additional devicetree fixups ......................................................................
Patch Set 26:
(7 comments)
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c File src/soc/cavium/cn81xx/soc.c:
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@79 PS26, Line 79: Remove 'phy-handle' if this option is not availble */ 'availble' may be misspelled - perhaps 'available'?
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@137 PS26, Line 137: /* Extract our MAC address info so we can assign them in the device tree */ line over 80 characters
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@169 PS26, Line 169: if (!strcmp(name, prop->prop.name)) { braces {} are not necessary for single statement blocks
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@265 PS26, Line 265: BDK_BGXX_CMRX_RX_DMAC_CTL(bgx_interface, bgx_index)); line over 80 characters
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@296 PS26, Line 296: /* ATF reserved */ code indent should use tabs where possible
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@297 PS26, Line 297: bootmem_add_range(0, 1 * MiB, BM_MEM_RESERVED); code indent should use tabs where possible
https://review.coreboot.org/#/c/25382/26/src/soc/cavium/cn81xx/soc.c@297 PS26, Line 297: bootmem_add_range(0, 1 * MiB, BM_MEM_RESERVED); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)