Attention is currently required from: Julius Werner. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56044 )
Change subject: [TESTONLY]do we use cbfs-relative base addresses as input?? ......................................................................
Patch Set 5:
(1 comment)
Patchset:
PS5:
I mean, if you remove this there'd be no more way at all to define a specific base for a file on non-x86 images, right? While I'm not aware of any board specifically using that right now it's probably not something we should make entirely impossible.
It looks like it's only used on x86 :-) It should not be removed indeed. I was gauging where cbfstool could be simplified as this parameter seems to be used in many different ways.
-
Arthur Heymans (Code Review)