Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86255?usp=email )
Change subject: mb/google/trulo/var/uldrenite: Add fw_config probe for Cellular
......................................................................
Patch Set 3:
(3 comments)
File src/mainboard/google/brya/variants/uldrenite/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/86255/comment/7be20b0b_b4477d1b?usp... :
PS2, Line 476: end
Should we also need to disable pcie_rp2 when CELLULAR_ABSENT? […]
Done
File src/mainboard/google/brya/variants/uldrenite/variant.c:
https://review.coreboot.org/c/coreboot/+/86255/comment/d661226e_3b2e21a0?usp... :
PS2, Line 67: {
The "{" and "}" will make no WWAN power sequence when fw_config is CELLULAR_RW350R.
Done
https://review.coreboot.org/c/coreboot/+/86255/comment/1e0fb802_6eb8aa0c?usp... :
PS2, Line 67: if (fw_config_probe(FW_CONFIG(DB_CELLULAR, CELLULAR_ABSENT))) {
: return;
: /*
: * RW350R power on seuqence:
: * De-assert WWAN_EN -> 20ms -> de-assert WWAN_RST -> 30ms ->
: * de-assert WWAN_PERST
: */
: gpio_configure_pads(rw350r_en_pad, ARRAY_SIZE(rw350r_en_pad));
: mdelay(RW350R_RST_DELAY_MS);
: gpio_configure_pads(rw350r_rst_pad, ARRAY_SIZE(rw350r_rst_pad));
: mdelay(RW350R_PERST_DELAY_MS);
: gpio_configure_pads(rw350r_perst_pad, ARRAY_SIZE(rw350r_perst_pad));
: }
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86255?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib664f543c6012b44a0a604d0943416519d92a057
Gerrit-Change-Number: 86255
Gerrit-PatchSet: 3
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Thu, 06 Feb 2025 05:50:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com