Martin Roth has posted comments on this change. ( https://review.coreboot.org/25926 )
Change subject: lenovo: Add various vbt.bin
......................................................................
Patch Set 1:
While I have no overall objection to the inclusion of these files, could we change the filename for all of the current vbts to something like data.vbt? This could also help with makefiles, since .bin is pretty generic, where as .vbt is specific as to the file type.
Since the data is documented, is it possible to save it as a text file and turn it into a binary with bincfg?
--
To view, visit
https://review.coreboot.org/25926
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I15573ddd37ee9738df1f7178f967131687a50f48
Gerrit-Change-Number: 25926
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin Roth
martinroth@google.com
Gerrit-Comment-Date: Mon, 30 Apr 2018 16:32:25 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No