Attention is currently required from: Jason Glenesk, Raul Rangel, Marshall Dawson, Angel Pons, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50570 )
Change subject: soc/amd/cezanne/acpi: Add plain soc.asl
......................................................................
Patch Set 2:
(1 comment)
File src/soc/amd/cezanne/acpi/soc.asl:
https://review.coreboot.org/c/coreboot/+/50570/comment/b37740c3_f91ce513
PS1, Line 6: arch/x86/acpi/globutil.asl
Kyösti, Are there any plans to move this into dsdt_top. […]
If there is nothing that conflicts with Intel, sounds like a good idea to do. Then again I am not sure if iasl has equivalent of garbage-collection or if it starts to complain about any defined but unused methods.
With a couple new board ports in review, I think I would try avoid touching dsdt_top.asl for couple weeks now. There is the idea of moving DSDT DefinitionBlock and probably a lot of mb/dsdt.asl could go under soc/ like <acpi/soc.asl>.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50570
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I227cdb7cb4848d1d26f6d7fa13ac2cc1aea08d1d
Gerrit-Change-Number: 50570
Gerrit-PatchSet: 2
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 12 Feb 2021 19:35:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment