Attention is currently required from: Bao Zheng, Jason Glenesk, ritul guru, Zheng Bao, Fred Reitberger.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72507 )
Change subject: amdfwtool: Add entry RIB whose subprog equals 1
......................................................................
Patch Set 2:
(1 comment)
File util/amdfwtool/data_parse.c:
https://review.coreboot.org/c/coreboot/+/72507/comment/9c3c0856_0e675dd8
PS2, Line 414: } else if (strcmp(fw_name, "PSP_RIB_FILE") == 0) {
for consistency i'd rename this one to PSP_RIB_FILE_SUB0
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72507
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib013f264fc9940ad95e559fe19bba72c06a19625
Gerrit-Change-Number: 72507
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Comment-Date: Wed, 01 Feb 2023 15:09:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment