Change in coreboot[master]: soc/intel/common/acpi: work around Windows crash on S0ix-enabled boards

[Michael Niewöhner (Code Review)]

Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47138 )

Change subject: soc/intel/common/acpi: work around Windows crash on S0ix-enabled boards
......................................................................

Patch Set 8:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... 
File src/soc/intel/common/block/acpi/acpi/pep.asl:

https://review.coreboot.org/c/coreboot/+/47138/8/src/soc/intel/common/block/... 
PS8, Line 32: 0,
> will do

hm, I've tried it but it makes it so damn unreadable... does that really provide useful information? I mean... it's a dummy package

Option 1:

~~~
 39 If(Arg2 == PEPD_DSM_ARG2_GET_DEVICE_CONSTRAINTS) {
 40         Return (Package() {     
 41                         Package() {             
 42                                 /* \DUMY - not existent */ 
 43                                 "\DUMY",               
 44                                 /* disabled, no constraints */
 45                                 0,  
 46                                 Package() {             
 47                                         /* revision */          
 48                                         0,                      
 49                                         Package() {             
 50                                                 /* apply to all LPIT states */
 51                                                 0xff,            
 52                                                 /* minimum D-state */
 53                                                 0                
 54                                         }                
 55                                 }                
 56                         }                
 57                 }
 58         )
 59 }
~~~

Option 2:

~~~
 39 If(Arg2 == PEPD_DSM_ARG2_GET_DEVICE_CONSTRAINTS) {
 40         Return (Package() {     
 41                         Package() {             
 42                                 "\DUMY",               /* \DUMY - not existent */ 
 43                                 0,                      /* disabled, no constraints */
 44                                 Package() {             
 45                                         0,              /* revision */
 46                                         Package() {             
 47                                                 0xff,   /* apply to all LPIT states */
 48                                                 0                       
 49                                         }                       
 50                                 }                       
 51                         }                       
 52                 }
 53         )
 54 }
~~~