HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
nb/intel/i945: Use 'const' to set pci_devfn_t statically
Change-Id: I879dd2fc61bc385486b506e2123f32629a67f518 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/northbridge/intel/i945/early_init.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/27/40227/1
diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index 368ebd2..d7bc1c6 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -498,10 +498,10 @@ u32 timeout; u32 reg32; u16 reg16; - pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0); + const pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0);
u8 tmp_secondary = 0x0a; - pci_devfn_t peg_plugin = PCI_DEV(tmp_secondary, 0, 0); + const pci_devfn_t peg_plugin = PCI_DEV(tmp_secondary, 0, 0);
printk(BIOS_DEBUG, "Enabling PCI Express x16 Link\n");
@@ -761,7 +761,7 @@ static void i945_setup_root_complex_topology(void) { u32 reg32; - pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0); + const pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0);
printk(BIOS_DEBUG, "Setting up Root Complex Topology\n"); /* Egress Port Root Topology */
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
Patch Set 1: Code-Review+1
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... PS1, Line 764: PCI_DEV(0, 0x01, 0) How about having these #defined somewhere?
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... PS1, Line 764: PCI_DEV(0, 0x01, 0)
How about having these #defined somewhere?
That would be nice for another patch.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... File src/northbridge/intel/i945/early_init.c:
https://review.coreboot.org/c/coreboot/+/40227/1/src/northbridge/intel/i945/... PS1, Line 764: PCI_DEV(0, 0x01, 0)
That would be nice for another patch.
Ack
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/40227 )
Change subject: nb/intel/i945: Use 'const' to set pci_devfn_t statically ......................................................................
nb/intel/i945: Use 'const' to set pci_devfn_t statically
Change-Id: I879dd2fc61bc385486b506e2123f32629a67f518 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/40227 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/northbridge/intel/i945/early_init.c 1 file changed, 3 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Paul Menzel: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/src/northbridge/intel/i945/early_init.c b/src/northbridge/intel/i945/early_init.c index 368ebd2..d7bc1c6 100644 --- a/src/northbridge/intel/i945/early_init.c +++ b/src/northbridge/intel/i945/early_init.c @@ -498,10 +498,10 @@ u32 timeout; u32 reg32; u16 reg16; - pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0); + const pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0);
u8 tmp_secondary = 0x0a; - pci_devfn_t peg_plugin = PCI_DEV(tmp_secondary, 0, 0); + const pci_devfn_t peg_plugin = PCI_DEV(tmp_secondary, 0, 0);
printk(BIOS_DEBUG, "Enabling PCI Express x16 Link\n");
@@ -761,7 +761,7 @@ static void i945_setup_root_complex_topology(void) { u32 reg32; - pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0); + const pci_devfn_t p2peg = PCI_DEV(0, 0x01, 0);
printk(BIOS_DEBUG, "Setting up Root Complex Topology\n"); /* Egress Port Root Topology */
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)
-
Paul Menzel (Code Review)