Attention is currently required from: Anil Kumar K, Tim Wawrzynczak, Paul Menzel, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62192 )
Change subject: soc/intel/common: Retry END_OF_POST command
......................................................................
Patch Set 12:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62192/comment/9c38463f_3a5519f6
PS11, Line 12:
nit: can you mention that this is from the BWG?
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/62192/comment/a8c4cad9_76f218e7
PS12, Line 11: max 3 times
Why not more?
ME BWG spec recommends only 3 times, hence I'm retrying thrice (including 1st attempt)
https://review.coreboot.org/c/coreboot/+/62192/comment/5a1c6dbb_ec0ad6ee
PS12, Line 15: TEST=Verify EOP retry mechanism for brya board.
How many tries are needed here?
Please see above. Are you asking something else?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62192
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieaec4d5564e3d962c1cc866351e9e7eaa8e58683
Gerrit-Change-Number: 62192
Gerrit-PatchSet: 12
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Sridhar Siricilla
sridhar.nest@gmail.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 10 Mar 2022 09:20:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment