Attention is currently required from: Arthur Heymans, Maximilian Brune, Philipp Hug.
ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81286?usp=email )
Change subject: arch/riscv: add constants for Base Extension ......................................................................
Patch Set 2:
(2 comments)
File src/arch/riscv/include/sbi.h:
https://review.coreboot.org/c/coreboot/+/81286/comment/54cd77d1_d890450d : PS1, Line 20: #define SBI_EXTENSION_ID 0x10
I would change the name to SBI_BASE_EXTENSION (makes it more easy to find the appropriate place in t […]
Done
https://review.coreboot.org/c/coreboot/+/81286/comment/4c238dc1_c241ca97 : PS1, Line 20: define SBI_EXTENSION_ID 0x10 : #define SBI_GET_SBI_SPEC_VERSION 0 : #define SBI_GET_SBI_IMPL_ID 1 : #define SBI_GET_SBI_IMPL_VERSION 2 : #define SBI_PROBE_EXTENSION 3 : #define SBI_GET_MVENDORID 4 : #define SBI_GET_MARCHID 5 : #define SBI_GET_MIMPID 6
maybe something like this: […]
Done