Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49025 )
Change subject: mb/clevo/cml-u: Rework Kconfig
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K...
File src/mainboard/clevo/cml-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/49025/3/src/mainboard/clevo/cml-u/K...
PS3, Line 21: _OPTIONS
I tried out your suggestion and I am getting this error while `git commit --amend`: […]
ugh. it is possible / Kconfig accepts it, I've just tested it, but the linter script warns for something that usually isn't a problem... anyway, we can revisit that later; thanks for trying, though
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49025
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1f5b6f535597149f28dd8c8322acc2e988f11505
Gerrit-Change-Number: 49025
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 04 Jan 2021 16:48:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
felixsinger@posteo.net
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment