Attention is currently required from: Angel Pons, Anil Kumar K, Jérémy Compostella.
Dinesh Gehlot has posted comments on this change. ( https://review.coreboot.org/c/libgfxinit/+/82147?usp=email )
Change subject: gma tgl: Pcode CDCLK_PREPARE_FOR_CHANGE is not mandatory
......................................................................
Patch Set 4: Verified+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/libgfxinit/+/82147/comment/8edc9a11_16c6183f :
PS2, Line 10: BIOS Reset CPL and may fail when called too early.
Would be nice to mention this in the commit message
Acknowledged
File common/tigerlake/hw-gfx-gma-power_and_clocks.adb:
https://review.coreboot.org/c/libgfxinit/+/82147/comment/b4eae5e6_a6972ee1 :
PS4, Line 331: not Config.CPU_Alderlake
Would be nice to turn this into a dedicated config variable.
Acknowledged! Added a dedicated config in a subsequent change [CL-82258](https://review.coreboot.org/c/libgfxinit/+/82258/1)
--
To view, visit
https://review.coreboot.org/c/libgfxinit/+/82147?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: libgfxinit
Gerrit-Branch: cros
Gerrit-Change-Id: I0514e404a7b580d1e35af7b39c1bd77183f11058
Gerrit-Change-Number: 82147
Gerrit-PatchSet: 4
Gerrit-Owner: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Angel Pons
angel.pons@9elements.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: Kapil Porwal
kapilporwal@google.com
Gerrit-CC: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Anil Kumar K
anil.kumar.k@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Angel Pons
angel.pons@9elements.com
Gerrit-Comment-Date: Wed, 08 May 2024 15:04:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dinesh Gehlot
digehlot@google.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment