Huayang Duan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34990 )
Change subject: mediatek/mt8183: Enable DRAM frequency 3600Mbps for EMCP DDR
......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/34990/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/34990/2//COMMIT_MSG@9
PS2, Line 9: 3600Mbs
Mbps
Done
https://review.coreboot.org/c/coreboot/+/34990/2//COMMIT_MSG@11
PS2, Line 11: proformance
performance
Done
https://review.coreboot.org/c/coreboot/+/34990/2/src/soc/mediatek/mt8183/emi...
File src/soc/mediatek/mt8183/emi.c:
https://review.coreboot.org/c/coreboot/+/34990/2/src/soc/mediatek/mt8183/emi...
PS2, Line 23: #define LP4X_HIGH_FREQ LP4X_DDR3600
: #define LP4X_MIDDLE_FREQ LP4X_DDR3200
: #define LP4X_LOW_FREQ LP4X_DDR1600
Consider aligning these 3 lines: […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34990
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iab6a9c2c390feeb9497b051a255b29566909e656
Gerrit-Change-Number: 34990
Gerrit-PatchSet: 3
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: SJ Huang
sj.huang@mediatek.corp-partner.google.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Wed, 28 Aug 2019 09:41:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment