build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63560 )
Change subject: [VERY WIP]tests/cpu/x86/smm: Add unit tests ......................................................................
Patch Set 22: Verified-1
(10 comments)
File tests/cpu/x86/smm/smm_loader.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/5bfe312b_e8c8efd2 PS22, Line 54: #define setup_rmodule(mod , c) \ space prohibited before that ',' (ctx:WxW)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/bcef6f42_feff2591 PS22, Line 54: #define setup_rmodule(mod , c) \ macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/67039c69_024ae076 PS22, Line 59: hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; \ line length of 97 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/f9f825b0_66b2aeef PS22, Line 66: hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program; \ line length of 100 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/89c07fd5_3afd850d PS22, Line 80: /* hdr->payload_begin_offset = (uintptr_t)(stub_module->program) - (uintptr_t)stub_module; */ line length of 101 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/9205b770_8e067e50 PS22, Line 87: /* hdr->parameters_begin = (uintptr_t)&stub_module->params - (uintptr_t)stub_module->program ; */ line length of 105 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/c476ae46_7964ab19 PS22, Line 93: /* stub_module->program[i] = stub_string[i % sizeof(stub_string)]; */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/d68d461b_91b4423a PS22, Line 106: hdr->payload_begin_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module; line length of 101 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/1d95fc90_5b30cb0e PS22, Line 107: hdr->payload_end_offset = (uintptr_t)(handler_module->program) - (uintptr_t)handler_module + sizeof(handler_module->program); line length of 133 exceeds 96 columns
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-150318): https://review.coreboot.org/c/coreboot/+/63560/comment/89f1934f_8ab00f11 PS22, Line 113: hdr->parameters_begin = (uintptr_t)&handler_module->params - (uintptr_t)handler_module->program; line length of 104 exceeds 96 columns
-
build bot (Jenkins) (Code Review)