Attention is currently required from: Timofey Komarov, Felix Singer, Angel Pons, Patrick Rudolph. Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52692 )
Change subject: soc/intel/skylake: Add Kconfig option for LGA1151v2 ......................................................................
Patch Set 10: Code-Review+2
(2 comments)
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/413c0b66_ebb05a54 PS9, Line 327: default y : : if SKYLAKE_SOC_PCH_H : : config MAINBOARD_SUPPORTS_KABYLAKE_CPU : bool "Board can contain Kaby Lake CPU" : default y if SOC_INTEL_KABYLAKE
These should `default n if SOC_INTEL_SKYLAKE_LGA1151_V2`.
Done
File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52692/comment/b6af62e9_9777df38 PS10, Line 333: default y if (!SOC_INTEL_SKYLAKE_LGA1151_V2 && SOC_INTEL_KABYLAKE) Nit, no parentheses needed. And as there is no other default line, it could also just say
default !SOC_INTEL_SKYLAKE_LGA1151_V2 && SOC_INTEL_KABYLAKE
-
Nico Huber (Code Review)