Change in coreboot[master]: drivers/i2c/designware: Report I2C timings for additional bus speeds - coreboot-gerrit

2 Jun 2021


      Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Werner Zeh, Kyösti Mälkki.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55088 )
Change subject: drivers/i2c/designware: Report I2C timings for additional bus speeds
......................................................................
Patch Set 4: Code-Review+1
(1 comment)
File src/drivers/i2c/designware/dw_i2c.c:
https://review.coreboot.org/c/coreboot/+/55088/comment/92756d84_80118da0 
PS3, Line 839: acpigen_pop_len
...
Oh, these functions are new (added in CB:50910), I wasn't aware. Thank you for the pointer. […]
Oops sorry yes, I meant acpigen_write_scope_end() 😊 They're great for readability!
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/55088
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If921e0613864660dc1bb8d7c1b30fb9db8ac655d
Gerrit-Change-Number: 55088
Gerrit-PatchSet: 4
Gerrit-Owner: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak twawrzynczak@google.com
Gerrit-Attention: Werner Zeh werner.zeh@siemens.com
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Wed, 02 Jun 2021 15:28:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Werner Zeh werner.zeh@siemens.com
Gerrit-MessageType: comment