Attention is currently required from: Дмитрий Понаморев, Mariusz Szafrański, Paul Menzel, Suresh Bellampalli, Vanessa Eusebio, Michal Motyl, Patrick Rudolph, King Sumo.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57194 )
Change subject: mb/teleplatforms/D4E4S16P8: Add new CRB teleplatforms/D4E4S16P8
......................................................................
Patch Set 18:
(3 comments)
File src/mainboard/teleplatforms/D4E4S16P8/gpio.h:
https://review.coreboot.org/c/coreboot/+/57194/comment/881d1883_3b9750ef
PS18, Line 9: const struct dnv_pad_config D4E4S16P8_gpio_table[] = {
No data, only prototypes and defines in .h files.
File src/mainboard/teleplatforms/D4E4S16P8/hsio.h:
https://review.coreboot.org/c/coreboot/+/57194/comment/c2e30d58_f933ffb1
PS18, Line 9: const BL_HSIO_INFORMATION D4E4S16P8_hsio_config[] = {
No data, only prototypes and defines in .h files.
File src/mainboard/teleplatforms/D4E4S16P8/ramstage.c:
https://review.coreboot.org/c/coreboot/+/57194/comment/e90fa7b9_4f7d8afc
PS18, Line 28: if (tmp == 0x3f/*?*/ || (tmp < 0x20 || tmp > 0x7f)) {
I'll recude this to BIOS_SPEW.
Do you want the serial number result string visible in the logs with BIOS_DEBUG? I think it should not be visible there.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If654fc7a391643b50f2e52755fd7c11a37bfd188
Gerrit-Change-Number: 57194
Gerrit-PatchSet: 18
Gerrit-Owner: Дмитрий Понаморев
dponamorev@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Reviewer: Michal Motyl
michalx.motyl@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: Дмитрий Понаморев
dponamorev@gmail.com
Gerrit-CC: King Sumo
kingsumos@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Дмитрий Понаморев
dponamorev@gmail.com
Gerrit-Attention: Mariusz Szafrański
mariuszx.szafranski@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Suresh Bellampalli
suresh.bellampalli@intel.com
Gerrit-Attention: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Attention: Michal Motyl
michalx.motyl@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: King Sumo
kingsumos@gmail.com
Gerrit-Comment-Date: Mon, 15 Nov 2021 15:30:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment