Attention is currently required from: Bao Zheng, Raul Rangel, Paul Menzel, Zheng Bao.
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54871 )
Change subject: amdfwtool: Set the region_type as 0 for entry "BIOS level 2"
......................................................................
Patch Set 2: -Code-Review
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/54871/comment/e770a758_d4243f44
PS2, Line 9: But we need to set it explicitly as
: a known value.
Thanks, though that’s unfortunate. […]
Or it's correcting an oversight first introduced in CB:33400, we're doing it for consistency, etc.
Also, the spec is NDA so you can cite the number but clarify that an NDA is required. You could also point to https://doc.coreboot.org/soc/amd/psp_integration.html, however.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/54871
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8b914f9f02beecce707aba86248826cd9208e6c0
Gerrit-Change-Number: 54871
Gerrit-PatchSet: 2
Gerrit-Owner: Bao Zheng
fishbaozi@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Bao Zheng
fishbaozi@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 27 May 2021 17:44:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Bao Zheng
fishbaozi@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment