Ravishankar Sarawadi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
mb/intel/tglrvp: Update Kconfig
Update Kconfig to add Tigerlake RVP board specific configs.
BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: I92a28592d9fbed9b858e14326de4f5921aa35016 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/Kconfig.name 2 files changed, 80 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/37926/1
diff --git a/src/mainboard/intel/tglrvp/Kconfig b/src/mainboard/intel/tglrvp/Kconfig index a45b29e..a4df59b 100644 --- a/src/mainboard/intel/tglrvp/Kconfig +++ b/src/mainboard/intel/tglrvp/Kconfig @@ -1,55 +1,89 @@ -if BOARD_INTEL_TGLRVP_UP3 - -config BOARD_SPECIFIC_OPTIONS - def_bool y - select BOARD_ROMSIZE_KB_16384 - select EC_ACPI - select GENERIC_SPD_BIN +config BOARD_INTEL_BASEBOARD_TGLRVP + def_bool n + select BOARD_ROMSIZE_KB_32768 + select DRIVERS_GENERIC_GPIO_KEYS + select DRIVERS_I2C_GENERIC + select DRIVERS_I2C_HID + select DRIVERS_I2C_MAX98373 + select DRIVERS_SPI_ACPI + select DRIVERS_USB_ACPI + select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_BOARDID + select GENERATE_SMBIOS_TABLES select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES - select MAINBOARD_INTEL_COMMON - select MAINBOARD_HAS_CHROMEOS - select GENERIC_SPD_BIN - select DRIVERS_I2C_HID - select DRIVERS_I2C_GENERIC - select DRIVERS_USB_ACPI - select SOC_INTEL_TIGERLAKE - select MAINBOARD_USES_IFD_EC_REGION select INTEL_LPSS_UART_FOR_CONSOLE + select MAINBOARD_HAS_CHROMEOS + select SOC_INTEL_TIGERLAKE
-config MAINBOARD_DIR - string - default "intel/tigerlake_rvp" - -config VARIANT_DIR - string - default "tglrvp" if BOARD_INTEL_TGLRVP_UP3 - -config MAINBOARD_PART_NUMBER - string - default "blackwall" - -config MAINBOARD_FAMILY - string - default "Intel_tigerlake_rvp" - -config MAX_CPUS - int - default 8 - -config DEVICETREE - string - default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" +if BOARD_INTEL_BASEBOARD_TGLRVP
config DIMM_SPD_SIZE int default 512
-config VBOOT - select VBOOT_LID_SWITCH - select VBOOT_MOCK_SECDATA +config GBB_HWID + string + depends on CHROMEOS + default "TGLRVP" if BOARD_INTEL_TGLRVP_UP3 + +config MAINBOARD_DIR + string + default "intel/tglrvp" + +config MAINBOARD_FAMILY + string + default "Intel_tglrvp" if BOARD_INTEL_TGLRVP_UP3 + +config MAINBOARD_PART_NUMBER + string + default "Tglrvp" if BOARD_INTEL_TGLRVP_UP3 + +config MAX_CPUS + int + default 8 + +config OEM_BIN_FILE + string "OEM ID table" + default ""
config UART_FOR_CONSOLE int default 2 + +config DEVICETREE + string + default "variants/$(CONFIG_VARIANT_DIR)/devicetree.cb" + +config VARIANT_DIR + string + default "tglrvp_up3" if BOARD_INTEL_TGLRVP_UP3 + +choice TGL_EC + prompt "ON BOARD EC" + default TGL_CHROME_EC + help + This option allows you to select the on board EC to use. + Select whether the board has Intel EC or Chrome EC + +config TGL_CHROME_EC + bool "Chrome EC" + select EC_GOOGLE_CHROMEEC + select EC_GOOGLE_CHROMEEC_ESPI + select EC_ACPI + select GBB_FLAG_FORCE_DEV_SWITCH_ON + select GBB_FLAG_FORCE_DEV_BOOT_USB + +config TGL_INTEL_EC + bool "Intel EC" + select EC_ACPI + select GBB_FLAG_DISABLE_EC_SOFTWARE_SYNC +endchoice + +config VBOOT + select VBOOT_LID_SWITCH + select EC_GOOGLE_CHROMEEC_SWITCHES + select VBOOT_MOCK_SECDATA + select HAS_RECOVERY_MRC_CACHE + select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN endif diff --git a/src/mainboard/intel/tglrvp/Kconfig.name b/src/mainboard/intel/tglrvp/Kconfig.name index 673a54c..42dc4d6 100644 --- a/src/mainboard/intel/tglrvp/Kconfig.name +++ b/src/mainboard/intel/tglrvp/Kconfig.name @@ -1,5 +1,6 @@ -config BOARD_INTEL_TGLRVP - bool "Tigerlake DDR4/LPDDR4 RVP" +comment "Tglrvp"
-config BOARD_INTEL_TGLRVP_EXT_EC - bool "Tigerlake DDR4/LPDDR4 RVP with Chrome EC" +config BOARD_INTEL_TGLRVP_UP3 + bool "-> Tglrvp" + select BOARD_INTEL_BASEBOARD_TGLRVP +
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 2: n Is this correct?
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 10: select EC_GOOGLE_CHROMEEC : select EC_GOOGLE_CHROMEEC_BOARDID This should be under Chrome EC config
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 28: default "TGLRVP" if BOARD_INTEL_TGLRVP_UP3 If BOARD_INTEL_TGLRVP_UP3 condition is used, we should use UP3 specific. TGLRVP is common for other varients like UP4.
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 36: default "Intel_tglrvp" if BOARD_INTEL_TGLRVP_UP If BOARD_INTEL_TGLRVP_UP3 condition is used, we should use UP3 specific. TGLRVP is common for other varients like UP4.
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 40: default "Tglrvp" if BOARD_INTEL_TGLRVP_UP3 If BOARD_INTEL_TGLRVP_UP3 condition is used, we should use UP3 specific. TGLRVP is common for other varients like UP4.
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 72: select EC_GOOGLE_CHROMEEC_ESPI select EC_GOOGLE_CHROMEEC_BOARDID need to be here
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 74: select GBB_FLAG_FORCE_DEV_SWITCH_ON : select GBB_FLAG_FORCE_DEV_BOOT_USB Is it only required Chrome EC case?
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... File src/mainboard/intel/tglrvp/Kconfig.name:
https://review.coreboot.org/c/coreboot/+/37926/2/src/mainboard/intel/tglrvp/... PS2, Line 4: "-> Tglrvp" "Tigerlake UP3 RVP"
Wonkyu Kim has uploaded a new patch set (#3) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
mb/intel/tglrvp: Update Kconfig
Update Kconfig to add Tigerlake RVP board specific configs.
BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: I92a28592d9fbed9b858e14326de4f5921aa35016 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/Kconfig.name 2 files changed, 79 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/37926/3
Wonkyu Kim has uploaded a new patch set (#4) to the change originally created by Ravishankar Sarawadi. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
mb/intel/tglrvp: Update Kconfig
Update Kconfig to add Tigerlake RVP board specific configs.
BUG=none BRANCH=none TEST=Build and boot tigerlake rvp board
Signed-off-by: Ravi Sarawadi ravishankar.sarawadi@intel.com Change-Id: I92a28592d9fbed9b858e14326de4f5921aa35016 --- M src/mainboard/intel/tglrvp/Kconfig M src/mainboard/intel/tglrvp/Kconfig.name 2 files changed, 79 insertions(+), 45 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/26/37926/4
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
Patch Set 4: Code-Review-1
Update by other patches https://review.coreboot.org/c/coreboot/+/37868/ https://review.coreboot.org/c/coreboot/+/38148
Wonkyu Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
Patch Set 4:
Patch Set 4: Code-Review-1
Update by other patches https://review.coreboot.org/c/coreboot/+/37868/ https://review.coreboot.org/c/coreboot/+/38148
Abandon this patch
Ravishankar Sarawadi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37926 )
Change subject: mb/intel/tglrvp: Update Kconfig ......................................................................
Abandoned
Not needed, old.