Change in coreboot[master]: soc/intel/common: Call EC _PTS/_WAK methods if defined - coreboot-gerrit

6 Nov 2018


      Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/29487 )
Change subject: soc/intel/common: Call EC _PTS/_WAK methods if defined
......................................................................
Patch Set 1:
...
Patch Set 1:
Looks like condrefof only works for the If statement and trying to actually call the method, even if it will not reach that code, causes the ASL compiler to fail.
I guess I will need to guard with a Kconfig option.
Aah yes. Does adding an External help:
External (_SB.PCI0.LPCB.EC0.WAK, MethodObj)
External (_SB.PCI0.LPCB.EC0.PTS, MethodObj)
-- 
To view, visit https://review.coreboot.org/29487
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6bf83509423c0fb07c4890986a189cf54afaed10
Gerrit-Change-Number: 29487
Gerrit-PatchSet: 1
Gerrit-Owner: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Duncan Laurie dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 06 Nov 2018 17:02:14 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No