Attention is currently required from: Raul Rangel. Hello build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/52673
to look at the new patch set (#2).
Change subject: mb/google/guybrush: Fix EC SCI configuration ......................................................................
mb/google/guybrush: Fix EC SCI configuration
This change fixes two problems: 1) We had the enum values for .direction and .level swapped. The naming is very confusing... 2) ESPI_SYS is not a good event to use for EC SCI. It is a level/low event that is only cleared by reading the eSPI status register 0x9C. Cezanne has added a new event source that directly exposes the SCI bit. This is the correct event source to use for EC SCI.
BUG=b:186045622, b:181139095 TEST=`lpc sci` on EC console and see /proc/interrupts increase by 1
Signed-off-by: Raul E Rangel rrangel@chromium.org Change-Id: I764b9ec202376d5124331a320767cbf79371dc07 --- M src/mainboard/google/guybrush/ec.c 1 file changed, 3 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/52673/2