Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Documentation: Add our issue tracker to services
Change-Id: Ib249d5c6f2431336a01850f4a8d708795983e7d3 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/community/services.md 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35806/1
diff --git a/Documentation/community/services.md b/Documentation/community/services.md index afdf040..8a5b0b4 100644 --- a/Documentation/community/services.md +++ b/Documentation/community/services.md @@ -33,3 +33,7 @@ After you push for review, the system will automatically verify your change and, if adhering to these constraints, approve it. You can then immediately submit it. + +## Issue tracker +There's an issue tracker at ticket.coreboot.org for the coreboot codebase, +associated projects like libpayload and the coreboot infrastructure.
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Patch Set 1:
(1 comment)
What about mentioning it here?
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... File Documentation/community/services.md:
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... PS1, Line 39: . The reference to these issues can be provided in the commit message on gerrit as:
Fixes: https://ticket.coreboot.org/issues/#id
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... File Documentation/community/services.md:
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... PS1, Line 38: There's an issue tracker at ticket.coreboot.org for the coreboot codebase, please make it a clickable hyperlink
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... File Documentation/community/services.md:
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... PS1, Line 38: There's an issue tracker at ticket.coreboot.org for the coreboot codebase,
please make it a clickable hyperlink
Done
https://review.coreboot.org/c/coreboot/+/35806/1/Documentation/community/ser... PS1, Line 39: .
The reference to these issues can be provided in the commit message on gerrit as: […]
Done
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35806
to look at the new patch set (#3).
Change subject: Documentation: Add our issue tracker to services ......................................................................
Documentation: Add our issue tracker to services
Change-Id: Ib249d5c6f2431336a01850f4a8d708795983e7d3 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M Documentation/community/services.md 1 file changed, 9 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/06/35806/3
Name of user not set #1002476 has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Patch Set 3: Code-Review+1
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35806 )
Change subject: Documentation: Add our issue tracker to services ......................................................................
Documentation: Add our issue tracker to services
Change-Id: Ib249d5c6f2431336a01850f4a8d708795983e7d3 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35806 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Rudolph siro@das-labor.org --- M Documentation/community/services.md 1 file changed, 9 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Rudolph: Looks good to me, approved Name of user not set #1002476: Looks good to me, but someone else must approve
diff --git a/Documentation/community/services.md b/Documentation/community/services.md index 0871cda..07c6f2c 100644 --- a/Documentation/community/services.md +++ b/Documentation/community/services.md @@ -34,3 +34,12 @@ After you push for review, the system will automatically verify your change and, if adhering to these constraints, approve it. You can then immediately submit it. + +## Issue tracker +We have an [issue tracker](https://ticket.coreboot.org) that is used for +coreboot and related code, such as libpayload, as well as for the project's +infrastructure. + +It can be helpful to refer to issues we track there in commit messages: + + Fixes: https://ticket.coreboot.org/issues/$id
-
Name of user not set (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)