[S] Change in coreboot[main]: cpu/x86/64bit/mode_switch: Work around FSP bug - coreboot-gerrit

6 Jan 2025


      Attention is currently required from: Arthur Heymans, Jérémy Compostella, Patrick Rudolph, Paul Menzel.
Shuo Liu has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/85789?usp=email )
Change subject: cpu/x86/64bit/mode_switch: Work around FSP bug
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
File src/cpu/x86/64bit/mode_switch.S:
https://review.coreboot.org/c/coreboot/+/85789/comment/125fd132_05474c92?usp... :
PS3, Line 50: 	lidt	-16(%ebp)
...
should it be lidt (%ebp)? (per ln22-27)
Sorry, my bad, it is the zero IDT instead of the back up IDT, no opens. LGTM.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/85789?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I56367d8153aa10a9b1bcaa5ffde8ebe202e8c00c
Gerrit-Change-Number: 85789
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Shuo Liu shuo.liu@intel.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Attention: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Mon, 06 Jan 2025 04:49:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Shuo Liu shuo.liu@intel.com