Change in coreboot[master]: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE`

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Paul Menzel (Code Review)

9 Nov 2020 9 Nov '20

1:54 p.m.

Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47363 )

Change subject: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` ......................................................................

mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE`

The Asus F2A85-M, F2A85-M LE and F2A85-M PRO all have a Super I/O, and therefore have legacy devices like a serial console.

Selecting `HUDSON_LEGACY_FREE` currently disable the serial console during bootup in romstage, which is undesired.

So, deselect the symbol by default.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47363/1

diff --git a/src/mainboard/asus/f2a85-m/Kconfig b/src/mainboard/asus/f2a85-m/Kconfig index 27d5517..326fedd9 100644 --- a/src/mainboard/asus/f2a85-m/Kconfig +++ b/src/mainboard/asus/f2a85-m/Kconfig @@ -84,7 +84,7 @@

config HUDSON_LEGACY_FREE bool - default y + default n

config POST_IO bool

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

9 Nov 9 Nov

1:55 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

Hello Mike Banon, Marshall Dawson, Idwer Vollering, Rudolf Marek, Felix Held,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/47363

to look at the new patch set (#2).

Change subject: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console ......................................................................

mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

The Asus F2A85-M, F2A85-M LE and F2A85-M PRO all have a Super I/O, and therefore have legacy devices like a serial console.

Selecting `HUDSON_LEGACY_FREE` currently disable the serial console during bootup in romstage, which is undesired.

So, deselect the symbol by default.

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/47363/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6588c0d4b2c24c7cb9da04805d13274c8ae295e Gerrit-Change-Number: 47363 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz Gerrit-MessageType: newpatchset

Felix Held (Code Review)

1:57 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47363 )

Change subject: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/47363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6588c0d4b2c24c7cb9da04805d13274c8ae295e Gerrit-Change-Number: 47363 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 09 Nov 2020 13:57:35 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Mike Banon (Code Review)

10 Nov 10 Nov

6:36 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47363 )

Change subject: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console ......................................................................

Patch Set 2: Code-Review+2

Seems to be a good idea. I.e. a very similar board - ASUS A88XM-E - already has this disabled in its' Kconfig.

-- To view, visit https://review.coreboot.org/c/coreboot/+/47363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6588c0d4b2c24c7cb9da04805d13274c8ae295e Gerrit-Change-Number: 47363 Gerrit-PatchSet: 2 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Tue, 10 Nov 2020 18:36:26 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Felix Held (Code Review)

7 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47363 )

Change subject: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console ......................................................................

mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

The Asus F2A85-M, F2A85-M LE and F2A85-M PRO all have a Super I/O, and therefore have legacy devices like a serial console.

Selecting `HUDSON_LEGACY_FREE` currently disable the serial console during bootup in romstage, which is undesired.

So, deselect the symbol by default.

TEST=Boot Asus F2A85-M PRO and verify serial console is *not* disabled during romstage. Change-Id: Ia6588c0d4b2c24c7cb9da04805d13274c8ae295e Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/47363 Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Mike Banon mikebdp2@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/asus/f2a85-m/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Mike Banon: Looks good to me, approved

config HUDSON_LEGACY_FREE bool - default y + default n

config POST_IO bool

-- To view, visit https://review.coreboot.org/c/coreboot/+/47363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6588c0d4b2c24c7cb9da04805d13274c8ae295e Gerrit-Change-Number: 47363 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

9elements QA (Code Review)

8:20 p.m.

New subject: Change in coreboot[master]: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47363 )

Change subject: mb/asus/f2a85-m: Disable `HUDSON_LEGACY_FREE` for working serial console ......................................................................

Patch Set 3:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/1/4 "HP Compaq 8200 Elite SFF PC" (x86_32) using payload TianoCore : FAIL : https://lava.9esec.io/r/27071 "QEMU x86 q35/ich9" (x86_32) using payload TianoCore : SUCCESS : https://lava.9esec.io/r/27069 "QEMU x86 q35/ich9" (x86_32) using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/27068 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/27067

Please note: This test is under development and might not be accurate at all!

-- To view, visit https://review.coreboot.org/c/coreboot/+/47363 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ia6588c0d4b2c24c7cb9da04805d13274c8ae295e Gerrit-Change-Number: 47363 Gerrit-PatchSet: 3 Gerrit-Owner: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de Gerrit-Reviewer: Idwer Vollering vidwer@gmail.com Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com Gerrit-Reviewer: Mike Banon mikebdp2@gmail.com Gerrit-Reviewer: Rudolf Marek r.marek@assembler.cz Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: 9elements QA hardwaretestrobot@gmail.com Gerrit-Comment-Date: Tue, 10 Nov 2020 20:20:22 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

1478

days inactive

1479

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

9elements QA (Code Review)
Felix Held (Code Review)
Mike Banon (Code Review)
Paul Menzel (Code Review)