Attention is currently required from: Václav Straka.
Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
Change subject: mb/hp: Add Pro 3400 ......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85825/comment/e11073d6_fe483e2f?usp... : PS1, Line 11: As a side effect fixed 3500's USB. (broken since 81878) I'm basing this off https://doc.coreboot.org/contributing/gerrit_guidelines.html#recommendations...
Each patch should be kept to one logical change, which should be described in the title of the patch.
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85825/comment/7490d766_440d4521?usp... : PS1, Line 25: device ref pci_bridge off end
I tried finding a workaround for it, but leaving a redundant device in the overlay seems to be the o […]
Ah, right, there needs to be a device. I'd say use an EHCI device as dummy, with a comment saying why it's there
-
Angel Pons (Code Review)