Attention is currently required from: Martin L Roth, Shelley Chen, Yuval Peress.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81050?usp=email )
Change subject: brox: ish: Add Kconfigs for ISH
......................................................................
Patch Set 4:
(2 comments)
File src/mainboard/google/brox/Kconfig:
https://review.coreboot.org/c/coreboot/+/81050/comment/8aee2957_ca1c8ab2 :
PS4, Line 92: BOARD_GOOGLE_BROX
It should be BOARD_GOOGLE_BASEBOARD_BROX
https://review.coreboot.org/c/coreboot/+/81050/comment/2a6c5b73_d16e3267 :
PS4, Line 120: BOARD_GOOGLE_BASEBOARD_BROX
It should be BOARD_GOOGLE_BROX || BOARD_GOOGLE_BROX_EC_ISH
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81050?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ic670d550a9aaad64e52489d895b8aac2aee4b5ed
Gerrit-Change-Number: 81050
Gerrit-PatchSet: 4
Gerrit-Owner: Yuval Peress
peress@google.com
Gerrit-Reviewer: Li1 Feng
li1.feng@intel.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Karthik Ramasubramanian
kramasub@google.com
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Yuval Peress
peress@google.com
Gerrit-Attention: Shelley Chen
shchen@google.com
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Comment-Date: Thu, 07 Mar 2024 23:57:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment