Wim Vervoorn has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable Speed Step and dptf ......................................................................
mb/facebook/monolith: Enable Speed Step and dptf
Enable Speed Step and dptf.
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38131/1
diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index dbe36f0..39aac47 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -21,11 +21,14 @@ # LPC serial IRQ register "serirq_mode" = "SERIRQ_CONTINUOUS"
+ # Enable "Intel Speed Step Technology" + register "eist_enable" = "1" + # Enable "Intel Speed Shift Technology" register "speed_shift_enable" = "1"
# Enable DPTF - register "dptf_enable" = "0" + register "dptf_enable" = "1"
# FSP Configuration register "EnableAzalia" = "1"
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable Speed Step and dptf ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38131/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38131/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/monolith: Enable Speed Step and dptf SpeedStep and DPTF
https://review.coreboot.org/c/coreboot/+/38131/1/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38131/1/src/mainboard/facebook/mono... PS1, Line 24: # Enable "Intel Speed Step Technology" Remove dependency. Use '# Intel SpeedStep Technology'
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38131
to look at the new patch set (#2).
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
mb/facebook/monolith: Enable SpeedStep and DPTF
Enable SpeedStep and DPTF.
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38131/2
Hello Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38131
to look at the new patch set (#3).
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
mb/facebook/monolith: Enable SpeedStep and DPTF
Enable SpeedStep and DPTF.
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38131/3
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38131/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38131/1//COMMIT_MSG@7 PS1, Line 7: mb/facebook/monolith: Enable Speed Step and dptf
SpeedStep and DPTF
Done
https://review.coreboot.org/c/coreboot/+/38131/1/src/mainboard/facebook/mono... File src/mainboard/facebook/monolith/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/38131/1/src/mainboard/facebook/mono... PS1, Line 24: # Enable "Intel Speed Step Technology"
Remove dependency. […]
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/38131/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38131/3//COMMIT_MSG@9 PS3, Line 9: Enable SpeedStep and DPTF. This is the same as the commit summary, so I'd just drop it
Hello Angel Pons, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38131
to look at the new patch set (#4).
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
mb/facebook/monolith: Enable SpeedStep and DPTF
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38131/4
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38131/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/38131/3//COMMIT_MSG@9 PS3, Line 9: Enable SpeedStep and DPTF.
This is the same as the commit summary, so I'd just drop it
Done
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 4:
Looks like this branch needs to be rebased manually.
Hello Angel Pons, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38131
to look at the new patch set (#5).
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
mb/facebook/monolith: Enable SpeedStep and DPTF
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38131/5
Hello Angel Pons, Frans Hendriks, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/38131
to look at the new patch set (#6).
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
mb/facebook/monolith: Enable SpeedStep and DPTF
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 6 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/31/38131/6
Wim Vervoorn has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 6:
Patch Set 4:
Looks like this branch needs to be rebased manually.
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 6: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
Patch Set 6: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38131 )
Change subject: mb/facebook/monolith: Enable SpeedStep and DPTF ......................................................................
mb/facebook/monolith: Enable SpeedStep and DPTF
BUG=N/A TEST=tested using fwts on facebook monolith.
Change-Id: Ia3dd195f887055448d42a7584e2c88322f0ec44b Signed-off-by: Wim Vervoorn wvervoorn@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38131 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/facebook/monolith/devicetree.cb 1 file changed, 6 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Frans Hendriks: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/mainboard/facebook/monolith/devicetree.cb b/src/mainboard/facebook/monolith/devicetree.cb index 4a34cab..399d9af 100644 --- a/src/mainboard/facebook/monolith/devicetree.cb +++ b/src/mainboard/facebook/monolith/devicetree.cb @@ -20,10 +20,14 @@ # LPC serial IRQ register "serirq_mode" = "SERIRQ_CONTINUOUS"
- # Enable "Intel Speed Shift Technology" + # "Intel SpeedStep Technology" + register "eist_enable" = "1" + + # "Intel Speed Shift Technology" register "speed_shift_enable" = "1"
- register "dptf_enable" = "0" + # DPTF + register "dptf_enable" = "1"
# FSP Configuration register "EnableAzalia" = "1"
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
Nico Huber (Code Review)
-
Wim Vervoorn (Code Review)