Martin Roth has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/36177 )
Change subject: util/lint: Enforce SPDX licenses only in src/acpi directory ......................................................................
util/lint: Enforce SPDX licenses only in src/acpi directory
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I9241f96eed652c8ca72d4f4a94f860a875e55680 --- M util/lint/lint-stable-000-license-headers 1 file changed, 5 insertions(+), 13 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/36177/1
diff --git a/util/lint/lint-stable-000-license-headers b/util/lint/lint-stable-000-license-headers index 441e679..fcaf32c 100755 --- a/util/lint/lint-stable-000-license-headers +++ b/util/lint/lint-stable-000-license-headers @@ -1,22 +1,14 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0-only # This file is part of the coreboot project. # -# Copyright (C) 2016 Google Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# # DESCR: Check that files have license headers
+# Directories requiring SPDX Identifiers only +util/lint/lint-000-license-headers "src/acpi" SPDX_ONLY + # Top level -util/lint/lint-000-license-headers "src/acpi src/arch src/commonlib src/console \ +util/lint/lint-000-license-headers "src/arch src/commonlib src/console \ src/cpu src/device src/ec src/mainboard src/northbridge src/soc \ src/southbridge src/superio"
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36177 )
Change subject: util/lint: Enforce SPDX licenses only in src/acpi directory ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36177 )
Change subject: util/lint: Enforce SPDX licenses only in src/acpi directory ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36177/2/util/lint/lint-stable-000-l... File util/lint/lint-stable-000-license-headers:
https://review.coreboot.org/c/coreboot/+/36177/2/util/lint/lint-stable-000-l... PS2, Line 8: util/lint/lint-000-license-headers "src/acpi" SPDX_ONLY Move this line below "Top level" and remove the comment? That way we can shift directories between two "category" invocations of the lint script until any category is spdx_only which means we'll drop the other one.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36177 )
Change subject: util/lint: Enforce SPDX licenses only in src/acpi directory ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36177/2/util/lint/lint-stable-000-l... File util/lint/lint-stable-000-license-headers:
https://review.coreboot.org/c/coreboot/+/36177/2/util/lint/lint-stable-000-l... PS2, Line 8: util/lint/lint-000-license-headers "src/acpi" SPDX_ONLY
Move this line below "Top level" and remove the comment? That way we can shift directories between t […]
can be done in a follow up and shouldn't stop this from getting merged.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/36177 )
Change subject: util/lint: Enforce SPDX licenses only in src/acpi directory ......................................................................
util/lint: Enforce SPDX licenses only in src/acpi directory
Signed-off-by: Martin Roth martin@coreboot.org Change-Id: I9241f96eed652c8ca72d4f4a94f860a875e55680 Reviewed-on: https://review.coreboot.org/c/coreboot/+/36177 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: David Hendricks david.hendricks@gmail.com --- M util/lint/lint-stable-000-license-headers 1 file changed, 5 insertions(+), 13 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved
diff --git a/util/lint/lint-stable-000-license-headers b/util/lint/lint-stable-000-license-headers index 441e679..fcaf32c 100755 --- a/util/lint/lint-stable-000-license-headers +++ b/util/lint/lint-stable-000-license-headers @@ -1,22 +1,14 @@ #!/bin/sh +# SPDX-License-Identifier: GPL-2.0-only # This file is part of the coreboot project. # -# Copyright (C) 2016 Google Inc. -# -# This program is free software; you can redistribute it and/or modify -# it under the terms of the GNU General Public License as published by -# the Free Software Foundation; version 2 of the License. -# -# This program is distributed in the hope that it will be useful, -# but WITHOUT ANY WARRANTY; without even the implied warranty of -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the -# GNU General Public License for more details. -# -# # DESCR: Check that files have license headers
+# Directories requiring SPDX Identifiers only +util/lint/lint-000-license-headers "src/acpi" SPDX_ONLY + # Top level -util/lint/lint-000-license-headers "src/acpi src/arch src/commonlib src/console \ +util/lint/lint-000-license-headers "src/arch src/commonlib src/console \ src/cpu src/device src/ec src/mainboard src/northbridge src/soc \ src/southbridge src/superio"
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36177 )
Change subject: util/lint: Enforce SPDX licenses only in src/acpi directory ......................................................................
Patch Set 3:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : No test failed. EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : No test failed. EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : No test failed.
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
David Hendricks (Code Review)
-
Martin Roth (Code Review)
-
Patrick Georgi (Code Review)